Remove a bunch of references to @ExcludeFromJacocoGeneratedReport (#3269)

This marks a bunch of methods to be included in our code coverage
report.

I went through all the references, and I believe I left 3 categories of
things that are excluded:
1. Methods that are simply some variant of throw OperationNotSupported.
We have a lot of these, because we override parts of JDBC, but haven't
implemented all of it yet.
2. There's a handful of Hollow or NoOp classes. I want to investigate
these further, and validate whether we should (a) remove them or (b) at
least have tests that have them where there supposed to go
3. `PlannerDebuggerCommandHandler` -- I believe this command starts the
planner repl, so that you can step through the cascades planner
execution. Given that the planner repl is entirely internal, and
interactive, I feel like this is ok.
4. `LaunchSQLLine` - as noted in the comment on the class, this is just
a little helper to make it easier to debug with sqlline. I will add
though, that I removed some of the exceptions for things used by
SQLLine, so we may want tests that test SQLLine integration, at which
point we could debug from those tests, and thus delete `LaunchSQLLine`
entirely.

Author: ScottDugas

fdb-relational-api/src/main/java/com/apple/foundationdb/relational/api/RelationalDatabaseMetaData.java

@@ -243,13 +243,11 @@ default boolean nullsAreSortedAtEnd() throws SQLException {
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport
     default String getDatabaseProductName() throws SQLException {
         return DATABASE_PRODUCT_NAME;
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport
     default String getDatabaseProductVersion() throws SQLException {
         return BuildVersion.getInstance().getVersion();
     }
@@ -261,13 +259,11 @@ default String getDriverName() throws SQLException {
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport
     default String getDriverVersion() throws SQLException {
         return BuildVersion.getInstance().getVersion();
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport //nothing to test
     default int getDriverMajorVersion() {
         try {
             return BuildVersion.getInstance().getMajorVersion();
@@ -277,7 +273,6 @@ default int getDriverMajorVersion() {
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport //nothing to test
     default int getDriverMinorVersion() {
         try {
             return BuildVersion.getInstance().getMinorVersion();
@@ -347,13 +342,11 @@ default boolean storesMixedCaseQuotedIdentifiers() throws SQLException {
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport
     default String getIdentifierQuoteString() throws SQLException {
         return "\"";
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport
     default String getSQLKeywords() throws SQLException {
         return "";
     }
@@ -515,13 +508,11 @@ default boolean supportsExtendedSQLGrammar() throws SQLException {
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport
     default boolean supportsANSI92EntryLevelSQL() throws SQLException {
         return true;
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport
     default boolean supportsANSI92IntermediateSQL() throws SQLException {
         return false;
     }

fdb-relational-api/src/main/java/com/apple/foundationdb/relational/api/RelationalDriver.java

@@ -22,7 +22,6 @@
 
 import com.apple.foundationdb.relational.api.exceptions.RelationalException;
 import com.apple.foundationdb.relational.util.BuildVersion;
-import com.apple.foundationdb.relational.util.ExcludeFromJacocoGeneratedReport;
 
 import javax.annotation.Nonnull;
 import java.net.URI;
@@ -36,7 +35,6 @@
 /**
  * A Driver which is used to connect to a Relational Database.
  */
-@ExcludeFromJacocoGeneratedReport
 public interface RelationalDriver extends Driver {
 
     default RelationalConnection connect(@Nonnull URI url) throws SQLException {

fdb-relational-api/src/main/java/com/apple/foundationdb/relational/api/RelationalPreparedStatement.java

@@ -498,7 +498,6 @@ default void cancel() throws SQLException {
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport
     default SQLWarning getWarnings() throws SQLException {
         // For now, return null until warnings are implemented.
         // Throwing an exception stops all processing. See TODO (Implement JDBC Warnings in Relational embedded Driver)

fdb-relational-api/src/main/java/com/apple/foundationdb/relational/api/RelationalResultSet.java

@@ -359,13 +359,11 @@ default Object getObject(String columnLabel, Map<String, Class<?>> map) throws S
         throw new SQLFeatureNotSupportedException("Not implemented in the relational layer", ErrorCode.UNSUPPORTED_OPERATION.getErrorCode());
     }
 
-    @ExcludeFromJacocoGeneratedReport
     @Override
     default <T> T unwrap(Class<T> iface) throws SQLException {
         return iface.cast(this);
     }
 
-    @ExcludeFromJacocoGeneratedReport
     @Override
     default boolean isWrapperFor(Class<?> iface) throws SQLException {
         return iface.isInstance(this);

fdb-relational-api/src/main/java/com/apple/foundationdb/relational/api/RelationalResultSetMetaData.java

@@ -101,7 +101,6 @@ default int getScale(int column) throws SQLException {
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport
     default String getTableName(int column) throws SQLException {
         // Throwing an exception here messes up sqlline drawing results. Just do what Oracle apparently does here
         // and return an empty String for now until we implement ResultSet context attributes like table name.

fdb-relational-api/src/main/java/com/apple/foundationdb/relational/api/RelationalStatement.java

@@ -123,7 +123,6 @@ default void cancel() throws SQLException {
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport
     default SQLWarning getWarnings() throws SQLException {
         // Return null warnings for now until implemented.
         // Throwing an exception stops all processing.

fdb-relational-api/src/main/java/com/apple/foundationdb/relational/api/SqlTypeNamesSupport.java

@@ -22,8 +22,6 @@
 
 import com.apple.foundationdb.annotation.API;
 
-import com.apple.foundationdb.relational.util.ExcludeFromJacocoGeneratedReport;
-
 import java.sql.Array;
 import java.sql.Struct;
 import java.sql.Types;
@@ -36,7 +34,6 @@
  * recordlayer.
  */
 // Used by fdb-relational-jdbc module in JDBCRelationalArray.
-@ExcludeFromJacocoGeneratedReport
 @API(API.Status.EXPERIMENTAL)
 public final class SqlTypeNamesSupport {
     private SqlTypeNamesSupport() {

fdb-relational-api/src/main/java/com/apple/foundationdb/relational/util/Assert.java

@@ -32,7 +32,6 @@
 /**
  * A set of helper methods for validating input, pre-conditions, ... etc.
  */
-@ExcludeFromJacocoGeneratedReport //just assertions, hard to test in a useful way
 @API(API.Status.EXPERIMENTAL)
 public final class Assert {
 

fdb-relational-cli/src/main/java/com/apple/foundationdb/relational/cli/sqlline/Customize.java

@@ -21,9 +21,6 @@
 package com.apple.foundationdb.relational.cli.sqlline;
 
 import com.apple.foundationdb.annotation.API;
-
-import com.apple.foundationdb.relational.util.ExcludeFromJacocoGeneratedReport;
-
 import sqlline.BuiltInProperty;
 import sqlline.CommandHandler;
 import sqlline.OutputFormat;
@@ -45,6 +42,7 @@
  * on how this works. The main thing we add is output of Relational STRUCT and ARRAY missing from basic sqlline.
  */
 @API(API.Status.EXPERIMENTAL)
+@SuppressWarnings("unused") // retrieved by sqlline via reflection
 public class Customize extends sqlline.Application {
     // Overriding {@link #getDefaultInteractiveMode()}, and {@link #getConnectInteractiveModes()} doesn't work -- bug
     // because sqlline does this <code>new HashSet<>(new Application().getConnectInteractiveModes()))</code> -- so we have
@@ -57,22 +55,19 @@ public class Customize extends sqlline.Application {
      * @return Our options instance.
      */
     @Override
-    @ExcludeFromJacocoGeneratedReport // Hard to make a test that makes sense given this an sqlline internal.
     public SqlLineOpts getOpts(SqlLine sqlLine) {
         // Set do-not-ask-for-login credentials -- login not supported on Relational, not yet.
         sqlLine.getOpts().set(BuiltInProperty.CONNECT_INTERACTION_MODE, "notAskCredentials");
         return sqlLine.getOpts();
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport // Hard to make a test that makes sense given this an sqlline internal.
     public String getInfoMessage() {
         // Prepend 'Relational' to hint Relational context.
         return "Relational " + getVersion();
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport // Hard to make a test that makes sense given this an sqlline internal.
     public Map<String, OutputFormat> getOutputFormats(SqlLine sqlLine) {
         //        final Map<String, OutputFormat> outputFormats = new HashMap<>();
         //        outputFormats.put("vertical", new VerticalOutputFormat(sqlLine));
@@ -97,7 +92,6 @@ public Map<String, OutputFormat> getOutputFormats(SqlLine sqlLine) {
     }
 
     @Override
-    @ExcludeFromJacocoGeneratedReport // Hard to make a test that makes sense given this an sqlline internal.
     public Collection<CommandHandler> getCommandHandlers(SqlLine sqlLine) {
         // Make a copy of super handlers list to get around the super making the list unmodifiable.
         List<CommandHandler> handlers = new ArrayList<>(super.getCommandHandlers(sqlLine));

fdb-relational-cli/src/main/java/sqlline/SetSchema.java

@@ -21,8 +21,6 @@
 package sqlline;
 
 import com.apple.foundationdb.annotation.API;
-
-import com.apple.foundationdb.relational.util.ExcludeFromJacocoGeneratedReport;
 import org.jline.reader.Completer;
 
 import java.sql.SQLException;
@@ -36,7 +34,6 @@
 @SuppressWarnings("PMD.GuardLogStatement")
 @API(API.Status.EXPERIMENTAL)
 public class SetSchema extends AbstractCommandHandler {
-    @ExcludeFromJacocoGeneratedReport // Hard to make a test that makes sense given this an sqlline internal.
     public SetSchema(SqlLine sqlLine) {
         super(sqlLine, new String[]{"setschema", "ss"}, "Set Relational Schema: e.g. !ss <SCHEMA_NAME>.",
                 Collections.<Completer>emptyList());