Fix transactional insert throwing No Value Present in server (#3476)

This changes the transactional logic to correctly handle mutations

Fixes: #3475

Author: ScottDugas

fdb-relational-jdbc/src/test/java/com/apple/foundationdb/relational/jdbc/JDBCAutoCommitTest.java

@@ -84,7 +84,7 @@ void autoCommitOn() throws SQLException, IOException {
      * Run a test with commit and then read.
      */
     @Test
-    void commitThenRead() throws SQLException, IOException {
+    void directInsertCommitThenRead() throws SQLException, IOException {
         try (RelationalConnection connection = DriverManager.getConnection(getTestDbUri()).unwrap(RelationalConnection.class)) {
             connection.setAutoCommit(false);
 
@@ -100,6 +100,27 @@ void commitThenRead() throws SQLException, IOException {
         }
     }
 
+    /**
+     * Run a test with commit and then read.
+     */
+    @Test
+    void queryInsertCommitThenRead() throws SQLException, IOException {
+        try (RelationalConnection connection = DriverManager.getConnection(getTestDbUri()).unwrap(RelationalConnection.class)) {
+            connection.setAutoCommit(false);
+
+            try (RelationalStatement statement = connection.createStatement()) {
+                Assertions.assertFalse(statement.execute("INSERT INTO test_table VALUES (100, 'one hundred')"));
+                Assertions.assertEquals(1, statement.getUpdateCount());
+                connection.commit();
+
+                RelationalResultSet resultSet = statement.executeQuery("SELECT * FROM test_table");
+                assertNextResult(resultSet, 100, "one hundred");
+                assertNoNextResult(resultSet);
+                connection.commit();
+            }
+        }
+    }
+
     @Test
     void insertMultiCommitRead() throws SQLException, IOException {
         try (RelationalConnection connection = DriverManager.getConnection(getTestDbUri()).unwrap(RelationalConnection.class)) {

fdb-relational-server/src/main/java/com/apple/foundationdb/relational/server/jdbc/v1/TransactionRequestHandler.java

@@ -82,9 +82,13 @@ public void onNext(final TransactionalRequest transactionRequest) {
                 final FRL.Response response = frl.transactionalExecute(transactionalToken, request.getSql(),
                         request.getParameters().getParameterList(), fromProto(request.getOptions()));
 
-                StatementResponse.Builder statementResponseBuilder = StatementResponse.newBuilder()
-                        .setResultSet(response.getResultSet())
-                        .setRowCount(response.getRowCount());
+                StatementResponse.Builder statementResponseBuilder = StatementResponse.newBuilder();
+                if (response.isQuery()) {
+                    statementResponseBuilder.setResultSet(response.getResultSet());
+                }
+                if (response.isMutation()) {
+                    statementResponseBuilder.setRowCount(response.getRowCount());
+                }
 
                 responseBuilder.setExecuteResponse(statementResponseBuilder);
             } else if (transactionRequest.hasInsertRequest()) {