Skip to content

Commit 8927559

Browse files
authored
Update code version before running tests in release build (#3450)
This modifies the release build workflow so that we increment the version of local code before we go to run the tests. This makes it so that we correctly distinguish between the latest external version (which should have a version less than `!current_version`) and the current code version. This is necessary to unblock the release build, which is failing currently due to certain tests failing when run in mixed mode against the lateset published version due to expected differences. Overall, I think this is a better set-up for our tests, as the version that will actually run the tests is now closer to version that we will actually end up publishing. The only difference should be the release number, which _shouldn't_ matter, but it's good to be sure. This fixes #3449.
1 parent 1276081 commit 8927559

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

.github/workflows/release.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ jobs:
3939
# a) all the tests
4040
# b) the mixed-mode tests
4141
test:
42+
needs: [get-update-type]
4243
runs-on: ubuntu-latest
4344
permissions:
4445
contents: read
@@ -50,6 +51,12 @@ jobs:
5051
uses: ./actions/setup-base-env
5152
- name: Setup FDB
5253
uses: ./actions/setup-fdb
54+
# Increment the version here so that the version used in tests matches the eventually published version.
55+
# This is actually important in order to correctly choose appropriate external server versions during
56+
# mixed mode tests (see: https://github.com/FoundationDB/fdb-record-layer/issues/3449)
57+
- name: Increment version
58+
shell: bash
59+
run: python build/versionutils.py gradle.properties --increment -u ${{ needs.get-update-type.outputs.update-type }}
5360
- name: Run Gradle Test
5461
uses: ./actions/gradle-test
5562
with:

0 commit comments

Comments
 (0)