Skip to content

Commit bdedab9

Browse files
committed
fix test
1 parent fc8bbde commit bdedab9

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/query/expressions/Comparisons.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,8 @@ private static boolean compareEquals(@Nonnull Object value, @Nonnull Object comp
246246
}
247247
}
248248

249-
@Nullable
250249
@SpotBugsSuppressWarnings("NP_BOOLEAN_RETURN_NULL")
251-
private static Boolean compareNotDistinctFrom(Object value, Object comparand) {
250+
private static boolean compareNotDistinctFrom(Object value, Object comparand) {
252251
if (value == null && comparand == null) {
253252
return true;
254253
} else if (value == null || comparand == null) {

fdb-record-layer-core/src/test/java/com/apple/foundationdb/record/query/expressions/QueryExpressionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ protected void testParameterComparison(String name, String field, Object val1, C
417417
final Bindings bindings = Bindings.newBuilder()
418418
.set("fooParam", val2)
419419
.build();
420-
if (val1 != null && val2 != null && (type == Comparisons.Type.IN && !(val2 instanceof List) || type.name().startsWith("TEXT_"))) {
420+
if (val1 != null && val2 != null && (type == Comparisons.Type.IN && !(val2 instanceof List)) || type.name().startsWith("TEXT_")) {
421421
assertThrows(name, RecordCoreException.class,
422422
() -> evaluate(qc, bindings, rec));
423423
} else {

0 commit comments

Comments
 (0)