Skip to content

Commit c1b3bd0

Browse files
authored
Have create_release_notes.py get the old version from ReleaseNotes.md (#3275)
This makes it dependent on ReleaseNotes.md, which makes sense. In addition, it now can only add one release at a time, which seems fine. I also added some tests, because I wanted to make sure it works without having to fetch commit history and whatnot. I still had to do some validation by running the command line, and found some bugs that way. I resolved those issues, and made it safer by adding type hints. I also, obviously, did not add any integration into prb for the tests, but that may be nice if we right more, they currently take less than a second.
1 parent daeac9f commit c1b3bd0

File tree

2 files changed

+229
-108
lines changed

2 files changed

+229
-108
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ jobs:
165165
--repository ${{ github.repository }} \
166166
--commit \
167167
--mixed-mode-results mixed-mode-results.md \
168-
${{ steps.get_old_version.outputs.version }} ${{ steps.get_new_version.outputs.version }}
168+
--version ${{ steps.get_new_version.outputs.version }}
169169
env:
170170
GH_TOKEN: ${{ github.token }}
171171
# We move the tag to after the release notes are updated so that later steps (i.e. sphinx) will pick up the udpated

0 commit comments

Comments
 (0)