Skip to content

Commit edf705c

Browse files
Fix code coverage (#52)
We changed how the CI/CD pipelines worked and needed to remove the lua_install folder from the coverage report.
1 parent 17cc241 commit edf705c

File tree

2 files changed

+1
-19
lines changed

2 files changed

+1
-19
lines changed

.github/workflows/test-and-coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,6 @@ jobs:
3838
- name: Report test coverage
3939
if: success()
4040
continue-on-error: true
41-
run: luacov-coveralls -e .luarocks
41+
run: luacov-coveralls -e lua_install
4242
env:
4343
COVERALLS_REPO_TOKEN: ${{ github.token }}

spec/parse_encode_spec.lua

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -115,24 +115,6 @@ describe("csv encode without quotes", function()
115115
end
116116
end)
117117

118-
--[[ This breaks simple_crlf.
119-
describe("csv encode with missing keys", function()
120-
for _, value in ipairs(files) do
121-
it("should handle " .. value, function()
122-
local jsonFile = loadFile("spec/json/" .. value .. ".json")
123-
local jsonDecode = cjson.decode(jsonFile)
124-
local reEncoded = ftcsv.parse(ftcsv.encode(
125-
jsonDecode, ",", {
126-
fieldsToKeep = {"a", "b", "c", "d"},
127-
allowMissingKeys = true,
128-
}
129-
), ",", {loadFromString=true})
130-
assert.are.same(jsonDecode, reEncoded)
131-
end)
132-
end
133-
end)
134-
--]]
135-
136118
describe("csv encode with missing keys", function()
137119
it("should handle missing_keys", function()
138120
local jsonFile = loadFile("spec/json/missing_keys.json")

0 commit comments

Comments
 (0)