Make UnknownItemDesc always output something.

Author: Fox2Code

loader/src/main/java/com/fox2code/foxloader/registry/missing/MissingItemDesc.java

@@ -48,7 +48,11 @@ public void runDesc(World world, List<String> list, ItemStack itemStack) {
             int itemId = itemStack.getItemID();
             remoteRawId = GameRegistry.itemIdMappingLocalNames[itemId];
             isBlock = GameRegistry.isItemBlock(itemId);
-            if (remoteRawId == null) return;
+            if (remoteRawId == null) {
+                remoteRawId = itemStack.hasRemoteID() ?
+                        ("Unknown remote id: " + itemStack.getRemoteItemID()) :
+                        ("Unknown local id: " + itemStack.getItemID());
+            }
         }
         if ("foxloader:item_missing".equals(remoteRawId) ||
                 "foxloader:block_missing".equals(remoteRawId)) {

patching/src/main/java/com/fox2code/foxloader/patching/game/RegistryPatch.java

@@ -538,6 +538,20 @@ private static void patchItemStackNet(ClassNode classNode) {
         setRemoteItemID.instructions.add(new InsnNode(RETURN));
         TransformerUtils.setThisParameterName(classNode, setRemoteItemID);
         TransformerUtils.setParameterName(setRemoteItemID, 1, "netItemID");
+        // Has remote id
+        MethodNode hasRemoteID = new MethodNode(ACC_PUBLIC, "hasRemoteID", "()Z", null, null);
+        classNode.methods.add(hasRemoteID);
+        hasRemoteID.instructions.add(new VarInsnNode(ALOAD, 0));
+        hasRemoteID.instructions.add(new FieldInsnNode(GETFIELD, ItemStack, "netItemID", "I"));
+        hasRemoteID.instructions.add(TransformerUtils.getNumberInsn(-1));
+        LabelNode ifNegOne = new LabelNode();
+        hasRemoteID.instructions.add(new JumpInsnNode(IF_ICMPEQ, ifNegOne));
+        hasRemoteID.instructions.add(TransformerUtils.getBooleanInsn(true));
+        hasRemoteID.instructions.add(new InsnNode(IRETURN));
+        hasRemoteID.instructions.add(ifNegOne);
+        hasRemoteID.instructions.add(TransformerUtils.getBooleanInsn(false));
+        hasRemoteID.instructions.add(new InsnNode(IRETURN));
+        TransformerUtils.setThisParameterName(classNode, hasRemoteID);
     }
 
     private static void patchPacket(ClassNode classNode) {