Skip to content

Commit 11393b9

Browse files
authored
Merge pull request #270 from vlvkobal/fix-ja4d
2 parents fd2dba8 + 11ae927 commit 11393b9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

wireshark/source/packet-ja4.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1495,7 +1495,7 @@ static int dissect_ja4(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void
14951495
}
14961496
if (strcmp(field->hfinfo->abbrev, "dhcp.option.type") == 0) {
14971497
unsigned val = fvalue_get_uinteger(get_value_ptr(field));
1498-
if (val != 0 && val != 53) {
1498+
if (val != 0 && val != 53 && val != 50 && val != 81) {
14991499
wmem_strbuf_append_printf(ja4d_data.options, "%d-", val);
15001500
}
15011501
}

wireshark/test/testdata/dhcp.pcapng.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"1"
99
],
1010
"ja4.ja4d": [
11-
"disco0000in_61-50-55_1-3-6-42"
11+
"disco0000in_61-55_1-3-6-42"
1212
]
1313
}
1414
}
@@ -36,7 +36,7 @@
3636
"3"
3737
],
3838
"ja4.ja4d": [
39-
"reqst0000in_61-50-54-55_1-3-6-42"
39+
"reqst0000in_61-54-55_1-3-6-42"
4040
]
4141
}
4242
}

0 commit comments

Comments
 (0)