Skip to content

Commit ab9ff48

Browse files
fix: error handled and removed console logs from the front-end code (microsoft#53)
* error handled and removed console logs * extra spaces removed
1 parent 3bf5016 commit ab9ff48

File tree

3 files changed

+43
-52
lines changed

3 files changed

+43
-52
lines changed

src/frontend/wwwroot/app.js

Lines changed: 43 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
(() => {
22
window.headers = GetAuthDetails();
3-
const apiEndpoint = BACKEND_API_URL;
3+
const apiEndpoint = sessionStorage.getItem('apiEndpoint') || BACKEND_API_URL;
44
const goHomeButton = document.getElementById("goHomeButton");
55
const newTaskButton = document.getElementById("newTaskButton");
66
const closeModalButtons = document.querySelectorAll(".modal-close-button");
@@ -27,21 +27,21 @@
2727
};
2828

2929
const switchView = () => {
30-
console.log("switchView called");
3130
const viewIframe = document.getElementById('viewIframe');
32-
const viewRoute = getQueryParam('v');
33-
console.log("viewRoute:", viewRoute);
34-
const viewContext = sessionStorage.getItem('context');
35-
const noCache = '?nocache=' + new Date().getTime();
36-
switch (viewRoute) {
37-
case 'home':
38-
viewIframe.src = 'home/home.html' + noCache;
39-
break;
40-
case 'task':
41-
viewIframe.src = `task/${viewContext}.html` + noCache;
42-
break;
43-
default:
44-
viewIframe.src = 'home/home.html';
31+
if (viewIframe) {
32+
const viewRoute = getQueryParam('v');
33+
const viewContext = sessionStorage.getItem('context');
34+
const noCache = '?nocache=' + new Date().getTime();
35+
switch (viewRoute) {
36+
case 'home':
37+
viewIframe.src = 'home/home.html' + noCache;
38+
break;
39+
case 'task':
40+
viewIframe.src = `task/${viewContext}.html` + noCache;
41+
break;
42+
default:
43+
viewIframe.src = 'home/home.html';
44+
}
4545
}
4646
};
4747
// get user session
@@ -55,7 +55,6 @@
5555
return null;
5656
}
5757
const payload = await response.json();
58-
console.log(payload)
5958

6059
if (payload) {
6160
return payload;
@@ -75,17 +74,21 @@
7574
};
7675

7776
const homeActions = () => {
78-
newTaskButton.addEventListener('click', (event) => {
79-
event.preventDefault();
80-
setQueryParam('v', 'home');
81-
switchView();
82-
});
83-
goHomeButton.addEventListener('click', (event) => {
84-
event.preventDefault();
85-
setQueryParam('v', 'home');
86-
switchView();
87-
});
77+
if (newTaskButton && goHomeButton) {
78+
newTaskButton.addEventListener('click', (event) => {
79+
event.preventDefault();
80+
setQueryParam('v', 'home');
81+
switchView();
82+
});
83+
84+
goHomeButton.addEventListener('click', (event) => {
85+
event.preventDefault();
86+
setQueryParam('v', 'home');
87+
switchView();
88+
});
89+
}
8890
};
91+
8992
const messageListeners = () => {
9093

9194
window.addEventListener('message', (event) => {
@@ -119,9 +122,9 @@
119122
.then(response => response.json())
120123
.then(data => {
121124

122-
console.log('getMyTasks', data);
123-
124-
myTasksMenu.innerHTML = '';
125+
if (myTasksMenu){
126+
myTasksMenu.innerHTML = '';
127+
}
125128

126129
if (data && data.length > 0) {
127130

@@ -148,8 +151,10 @@
148151
<div class="tag is-dark ml-3">${completedSteps}/${task.total_steps}</div>
149152
</a>
150153
`;
151-
152-
myTasksMenu.appendChild(newTaskItem);
154+
155+
if(myTasksMenu){
156+
myTasksMenu.appendChild(newTaskItem);
157+
}
153158

154159
newTaskItem.querySelector('.menu-task').addEventListener('click', (event) => {
155160
const sessionId = event.target.closest('.menu-task').dataset.id;
@@ -177,11 +182,13 @@
177182
if (task.overall_status === 'rejected') stagesRejectedCount++;
178183

179184
const addS = (word, count) => (count === 1) ? word : word + 's';
180-
181-
tasksStats.innerHTML = `
182-
<li><a><strong>${inCompletedTaskCount}</strong> ${addS('task', inCompletedTaskCount)} completed</a></li>
183-
<li><a><strong>${inProgressTaskCount}</strong> ${addS('task', inProgressTaskCount)} in progress</a></li>
184-
`;
185+
186+
if(tasksStats){
187+
tasksStats.innerHTML = `
188+
<li><a><strong>${inCompletedTaskCount}</strong> ${addS('task', inCompletedTaskCount)} completed</a></li>
189+
<li><a><strong>${inProgressTaskCount}</strong> ${addS('task', inProgressTaskCount)} in progress</a></li>
190+
`;
191+
}
185192

186193
taskCount++;
187194

@@ -215,7 +222,6 @@
215222
if (!userInfo) {
216223
console.error("Authentication failed. Access to tasks is restricted.");
217224
} else {
218-
console.log('Authenticated User Info:', userInfo);
219225
sessionStorage.setItem('userInfo', userInfo);
220226
await fetchTasksIfNeeded(); // Fetch tasks after initialization if needed
221227
}

src/frontend/wwwroot/home/home.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,6 @@
111111
return;
112112
}
113113

114-
console.log("startTaskButton", data);
115-
116114
newTaskPrompt.disabled = false;
117115
startTaskButton.disabled = false;
118116
startTaskButton.classList.remove("is-loading");

src/frontend/wwwroot/task/task.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,6 @@
204204
};
205205

206206
const fetchPlanDetails = async (session_id) => {
207-
console.log("/plans?session_id:", window.headers);
208-
209207
const headers = await window.headers;
210208

211209
return fetch(apiEndpoint + "/plans?session_id=" + session_id, {
@@ -214,8 +212,6 @@
214212
})
215213
.then((response) => response.json())
216214
.then((data) => {
217-
console.log("fetchPlanDetails", data[0]);
218-
219215
updateTaskStatusDetails(data[0]);
220216
updateTaskProgress(data[0]);
221217
fetchTaskStages(data[0]);
@@ -265,8 +261,6 @@
265261
})
266262
.then((response) => response.json())
267263
.then((data) => {
268-
console.log("fetchTaskStages", data);
269-
270264
if (taskStagesMenu) taskStagesMenu.innerHTML = "";
271265
let taskStageCount = 0;
272266
let taskStageApprovalStatus = 0;
@@ -402,8 +396,6 @@
402396
})
403397
.then((response) => response.json())
404398
.then((data) => {
405-
console.log("fetchTaskMessages", data);
406-
407399
const toAgentName = (str) => {
408400
return str.replace(/([a-z])([A-Z])/g, "$1 $2");
409401
};
@@ -445,8 +437,6 @@
445437
sessionStorage.getItem("context") &&
446438
sessionStorage.getItem("context") === "customer"
447439
) {
448-
console.log("contextFilter", contextFilter(data));
449-
450440
data = contextFilter(data);
451441
}
452442

@@ -674,7 +664,6 @@
674664
})
675665
.then((response) => response.json())
676666
.then((data) => {
677-
console.log("actionStage", data);
678667
action === "approved"
679668
? notyf.success(`Stage "${stageObj.action}" approved.`)
680669
: notyf.error(`Stage "${stageObj.action}" rejected.`);
@@ -826,8 +815,6 @@
826815
})
827816
.then((response) => response.json())
828817
.then((data) => {
829-
console.log("taskMessage", data);
830-
831818
taskMessageTextarea.disabled = false;
832819
taskMessageAddButton.disabled = false;
833820
taskMessageAddButton.classList.remove("is-loading");

0 commit comments

Comments
 (0)