bug symfony#20931 [VarDumper] Fix dumping by-ref variadics (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 4299dae7c0be · 2016-12-15T14:06:00.000+01:00
This PR was merged into the 2.7 branch. Discussion ---------- [VarDumper] Fix dumping by-ref variadics | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The correct php syntax is `&...$foo`, not ~~`...&$foo`~~ Commits ------- 28ec361 [VarDumper] Fix dumping by-ref variadics
diff --git a/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php b/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php
@@ -125,12 +125,12 @@ public static function castFunctionAbstract(\ReflectionFunctionAbstract $c, arra
 
         foreach ($c->getParameters() as $v) {
             $k = '$'.$v->name;
-            if ($v->isPassedByReference()) {
-                $k = '&'.$k;
-            }
             if (method_exists($v, 'isVariadic') && $v->isVariadic()) {
                 $k = '...'.$k;
             }
+            if ($v->isPassedByReference()) {
+                $k = '&'.$k;
+            }
             $a[$prefix.'parameters'][$k] = $v;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -125,12 +125,12 @@ public static function castFunctionAbstract(\ReflectionFunctionAbstract $c, arra`
`125`	`125`
`126`	`126`	`foreach ($c->getParameters() as $v) {`
`127`	`127`	`$k = '$'.$v->name;`
`128`		`- if ($v->isPassedByReference()) {`
`129`		`- $k = '&'.$k;`
`130`		`- }`
`131`	`128`	`if (method_exists($v, 'isVariadic') && $v->isVariadic()) {`
`132`	`129`	`$k = '...'.$k;`
`133`	`130`	`}`
	`131`	`+ if ($v->isPassedByReference()) {`
	`132`	`+ $k = '&'.$k;`
	`133`	`+ }`
`134`	`134`	`$a[$prefix.'parameters'][$k] = $v;`
`135`	`135`	`}`
`136`	`136`