[SecurityBundle] Make the FirewallConfig class final

ogizanagi · ogizanagi · commit 5963627d06de · 2016-11-04T13:57:00.000+01:00
diff --git a/src/Symfony/Bundle/SecurityBundle/Security/FirewallConfig.php b/src/Symfony/Bundle/SecurityBundle/Security/FirewallConfig.php
@@ -14,7 +14,7 @@
 /**
  * @author Robin Chalas <robin.chalas@gmail.com>
  */
-class FirewallConfig
+final class FirewallConfig
 {
     private $name;
     private $requestMatcher;
diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/Security/FirewallContextTest.php b/src/Symfony/Bundle/SecurityBundle/Tests/Security/FirewallContextTest.php
@@ -20,10 +20,7 @@ class FirewallContextTest extends \PHPUnit_Framework_TestCase
 {
     public function testGetters()
     {
-        $config = $this
-            ->getMockBuilder(FirewallConfig::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $config = new FirewallConfig('main', 'request_matcher');
 
         $exceptionListener = $this
             ->getMockBuilder(ExceptionListener::class)

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`/**`
`15`	`15`	`* @author Robin Chalas <[email protected]>`
`16`	`16`	`*/`
`17`		`-class FirewallConfig`
	`17`	`+final class FirewallConfig`
`18`	`18`	`{`
`19`	`19`	`private $name;`
`20`	`20`	`private $requestMatcher;`
Original file line number	Diff line number	Diff line change
`@@ -20,10 +20,7 @@ class FirewallContextTest extends \PHPUnit_Framework_TestCase`
`20`	`20`	`{`
`21`	`21`	`public function testGetters()`
`22`	`22`	`{`
`23`		`- $config = $this`
`24`		`- ->getMockBuilder(FirewallConfig::class)`
`25`		`- ->disableOriginalConstructor()`
`26`		`- ->getMock();`
	`23`	`+ $config = new FirewallConfig('main', 'request_matcher');`
`27`	`24`
`28`	`25`	`$exceptionListener = $this`
`29`	`26`	`->getMockBuilder(ExceptionListener::class)`