Skip to content

Commit 5ec7183

Browse files
wip(core): rename vueVersion with vueTarget (to avoid confusion with the exported symbol "vueVersion")
1 parent 1a96c7c commit 5ec7183

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

build/webpack.config.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const pkg = require('../package.json');
1616

1717
const distPath = Path.resolve(__dirname, '..', 'dist');
1818

19-
const configure = ({name, vueVersion}) => (env = {}, { mode = 'production', configName }) => {
19+
const configure = ({name, vueTarget}) => (env = {}, { mode = 'production', configName }) => {
2020
if (configName && !configName.includes(name)) {
2121
return {name}
2222
}
@@ -34,7 +34,7 @@ const configure = ({name, vueVersion}) => (env = {}, { mode = 'production', conf
3434

3535
const genSourcemap = false;
3636

37-
console.log('config', { targetsBrowsers, noPresetEnv, noCompress, noSourceMap, genSourcemap, vueVersion });
37+
console.log('config', { targetsBrowsers, noPresetEnv, noCompress, noSourceMap, genSourcemap, vueTarget });
3838

3939
return {
4040
name,
@@ -45,10 +45,10 @@ const configure = ({name, vueVersion}) => (env = {}, { mode = 'production', conf
4545

4646
output: {
4747
path: distPath,
48-
filename: `vue${ vueVersion }-sfc-loader.js`,
48+
filename: `vue${ vueTarget }-sfc-loader.js`,
4949
library: {
5050
type: 'umd',
51-
name: `vue${ vueVersion }-sfc-loader`,
51+
name: `vue${ vueTarget }-sfc-loader`,
5252
},
5353
environment: {
5454
// doc: https://webpack.js.org/configuration/output/#outputenvironment
@@ -153,7 +153,7 @@ const configure = ({name, vueVersion}) => (env = {}, { mode = 'production', conf
153153
// doc: https://github.com/webpack-contrib/webpack-bundle-analyzer#options-for-plugin
154154
analyzerMode: 'static',
155155
openAnalyzer: false,
156-
reportFilename: `vue${ vueVersion }-sfc-loader.report.html`
156+
reportFilename: `vue${ vueTarget }-sfc-loader.report.html`
157157
})
158158
] : [],
159159

@@ -170,7 +170,7 @@ ${ pkg.name } v${ pkg.version }
170170
mainFields: ['browser', 'main', 'module'],
171171
alias: {
172172

173-
'./createSFCModule': `./createVue${ vueVersion }SFCModule`,
173+
'./createSFCModule': `./createVue${ vueTarget }SFCModule`,
174174

175175
// dedupe (see DuplicatePackageCheckerPlugin result)
176176
'bn.js': require.resolve('bn.js'),
@@ -307,8 +307,8 @@ ${ pkg.name } v${ pkg.version }
307307
}
308308

309309
let configs = [
310-
{name: 'vue2', vueVersion: '2' },
311-
{name: 'vue3', vueVersion: '3' }
310+
{name: 'vue2', vueTarget: '2' },
311+
{name: 'vue3', vueTarget: '3' }
312312
]
313313

314314
module.exports = configs.map(configure)

tests/basic.test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
const { defaultFilesVue2, defaultFiles, createPage } = require('./testsTools.js');
22

33
[
4-
{desc: "vue 2", vueVersion: 2, files: defaultFilesVue2},
5-
{desc: "vue 3", vueVersion: 3, files: defaultFiles},
4+
{desc: "vue 2", vueTarget: 2, files: defaultFilesVue2},
5+
{desc: "vue 3", vueTarget: 3, files: defaultFiles},
66
]
7-
.filter(({ vueVersion }) => !process.env.vueVersion || vueVersion === Number(process.env.vueVersion) )
8-
.map(e => { console.log('tests vue ' + e.vueVersion); return e })
9-
.forEach(({desc, vueVersion, files}) => {
7+
.filter(({ vueTarget }) => !process.env.vueTarget || vueTarget === Number(process.env.vueTarget) )
8+
.map(e => { console.log('tests vue ' + e.vueTarget); return e })
9+
.forEach(({desc, vueTarget, files}) => {
1010
describe(desc, () => {
1111

1212

0 commit comments

Comments
 (0)