Skip to content

Commit 3b3f7d3

Browse files
committed
test: Fix tests
* mevedel-instructions.el: Hardcode `M-m` as default keybind for `mevedel-ov-dispatch-key` in order to avoid circular dependency. Also move `mevedel-ov-dispatch-key` to mevedel.el. * mevedel.el (mevedel-ov-dispatch-key): Add `mevedel-ov-dispatch-key`. * test/helpers.el: Remove `require` for `mevedel-instructions`, it is not needed.
1 parent 4a57f83 commit 3b3f7d3

3 files changed

Lines changed: 25 additions & 29 deletions

File tree

‎mevedel-instructions.el‎

Lines changed: 5 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1336,48 +1336,26 @@ CALLBACK is supplied by Eldoc, see `eldoc-documentation-functions'."
13361336
(propertize (gptel--model-name gptel-model) 'face 'mode-line-emphasis)))))
13371337

13381338

1339-
;; To appease the byte compiler
1340-
(defvar mevedel--actions-maps)
1341-
(defcustom mevedel-ov-dispatch-key "M-m"
1342-
"Keybind to open overlay actions.
1343-
If nil, no keybinding is set for dispatch actions."
1344-
:group 'mevedel
1345-
:type '(choice (const :tag "No keybinding" nil)
1346-
(string :tag "Key sequence"))
1347-
:set (lambda (sym new-val)
1348-
(let ((old-val (and (boundp sym) (symbol-value sym))))
1349-
;; Remove old binding if there was one and keymap exists
1350-
(dolist (map mevedel--actions-maps)
1351-
(when (and old-val (boundp map))
1352-
(keymap-set (symbol-value map) old-val nil)))
1353-
1354-
;; Set the new value
1355-
(set sym new-val)
1356-
;; Add new binding if new value is non-nil and keymap exists
1357-
(dolist (map mevedel--actions-maps)
1358-
(when (and new-val (boundp map))
1359-
(keymap-set (symbol-value map) new-val #'mevedel--ov-actions-dispatch))))))
1360-
13611339
(defvar-keymap mevedel-reference-actions-map
13621340
:doc "Keymap for `mevedel' reference overlay actions at point."
1363-
mevedel-ov-dispatch-key #'mevedel--ov-actions-dispatch)
1341+
"M-m" #'mevedel--ov-actions-dispatch)
13641342

13651343
(defvar-keymap mevedel-directive-actions-map
13661344
:doc "Keymap for `mevedel' directive overlay actions at point."
1367-
mevedel-ov-dispatch-key #'mevedel--ov-actions-dispatch)
1345+
"M-m" #'mevedel--ov-actions-dispatch)
13681346

13691347
(defvar-keymap mevedel-directive-processing-actions-map
13701348
:doc "Keymap for `mevedel' processing directive overlay actions at point."
1371-
mevedel-ov-dispatch-key #'mevedel--ov-actions-dispatch
1349+
"M-m" #'mevedel--ov-actions-dispatch
13721350
"C-c C-k" #'mevedel--ov-actions-abort)
13731351

13741352
(defvar-keymap mevedel-directive-succeeded-actions-map
13751353
:doc "Keymap for `mevedel' succeeded directive overlay actions at point."
1376-
mevedel-ov-dispatch-key #'mevedel--ov-actions-dispatch)
1354+
"M-m" #'mevedel--ov-actions-dispatch)
13771355

13781356
(defvar-keymap mevedel-directive-failed-actions-map
13791357
:doc "Keymap for `mevedel' failed directive overlay actions at point."
1380-
mevedel-ov-dispatch-key #'mevedel--ov-actions-dispatch)
1358+
"M-m" #'mevedel--ov-actions-dispatch)
13811359

13821360
(defvar mevedel--actions-maps '(mevedel-reference-actions-map
13831361
mevedel-directive-actions-map

‎mevedel.el‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,26 @@ you want to keep plans persistently."
8181
:type 'directory
8282
:group 'mevedel)
8383

84+
(defcustom mevedel-ov-dispatch-key "M-m"
85+
"Keybind to open overlay actions.
86+
If nil, no keybinding is set for dispatch actions."
87+
:group 'mevedel
88+
:type '(choice (const :tag "No keybinding" nil)
89+
(string :tag "Key sequence"))
90+
:set (lambda (sym new-val)
91+
(let ((old-val (and (boundp sym) (symbol-value sym))))
92+
;; Remove old binding if there was one and keymap exists
93+
(dolist (map mevedel--actions-maps)
94+
(when (and old-val (boundp map))
95+
(keymap-set (symbol-value map) old-val nil)))
96+
97+
;; Set the new value
98+
(set sym new-val)
99+
;; Add new binding if new value is non-nil and keymap exists
100+
(dolist (map mevedel--actions-maps)
101+
(when (and new-val (boundp map))
102+
(keymap-set (symbol-value map) new-val #'mevedel--ov-actions-dispatch))))))
103+
84104

85105
;;
86106
;;; Buffer management

‎test/helpers.el‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
;;; Code:
66

7-
(require 'mevedel-instructions)
8-
97

108
;;
119
;;; Test macro

0 commit comments

Comments
 (0)