Skip to content

Commit 3fd4a2e

Browse files
committed
attestationreport: snp log messages
Signed-off-by: Simon Ott <simon.ott@aisec.fraunhofer.de>
1 parent 9511486 commit 3fd4a2e

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

attestationreport/validationreport.go

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -830,15 +830,20 @@ func (r *VerificationResult) PrintErr() {
830830
m.Summary.PrintErr("%v", m.Type)
831831
m.Freshness.PrintErr("Measurement freshness check")
832832
m.Signature.PrintErr("Measurement")
833-
for _, a := range m.Artifacts {
833+
for i, a := range m.Artifacts {
834834
if !a.Success {
835-
header := ""
836-
if m.Type == "TPM Result" {
837-
header = fmt.Sprintf("PCR%v ", a.Index)
838-
} else if m.Type == "TDX Result" {
839-
header = fmt.Sprintf("%v ", internal.IndexToMr(a.Index))
835+
var header string
836+
switch m.Type {
837+
case "TPM Result":
838+
header = fmt.Sprintf("PCR%v Measurement", a.Index)
839+
case "TDX Result":
840+
header = fmt.Sprintf("%v Measurement", internal.IndexToMr(a.Index))
841+
case "SNP Result":
842+
header = "SNP Measurement"
843+
default:
844+
header = fmt.Sprintf("%v Measurement", m.Type)
840845
}
841-
log.Warnf("%vMeasurement %v: %v verification failed", header, a.SubType, a.Digest)
846+
log.Warnf("%v %q: %v verification failed (Artifact %v)", header, a.SubType, a.Digest, i)
842847
}
843848
}
844849
if m.TpmResult != nil {

verifier/snp.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,8 @@ func verifySnpMeasurements(measurement ar.Measurement, nonce []byte, manifests [
172172

173173
// Compare Measurements
174174
if cmp := bytes.Compare(s.Measurement[:], snpReferenceValue.Sha384); cmp != 0 {
175-
log.Debug("Failed to verify SNP reference value")
175+
log.Debugf("Failed to verify SNP reference value. Expected %x, got %x",
176+
snpReferenceValue.Sha384, s.Measurement[:])
176177
result.Artifacts = append(result.Artifacts,
177178
ar.DigestResult{
178179
Type: "Reference Value",

0 commit comments

Comments
 (0)