Skip to content

Commit 49fac3a

Browse files
authored
Merge pull request #309 from FredHutch/update-folder-names
Update "methods" folder name to "child-docs"
2 parents 81f6b30 + ac36d18 commit 49fac3a

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

NEWS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# VISCtemplates (development version)
22

33
Improvements for users
4+
* Change name of `methods` folder within each report subfolder to `child-docs` to be more general-purpose (#309)
45
* Line breaks added between multiple contact personnel on title page of PDF report template (#308)
56
* `visc_load_pdata()` gives more informative error message when serialized pdata file does not contain an R object of the same name (#303)
67
* Default behavior of `create_visc_project()` no longer includes creation of package-specific files DESCRIPTION and NAMESPACE (#306)

R/use_visc_report.R

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,15 +148,15 @@ use_visc_methods <- function(path = ".", assay = c("generic", "bama", "nab", "ad
148148

149149
pkg_ver <- utils::packageVersion("VISCtemplates")
150150

151-
usethis::use_directory(file.path(path, "methods"))
151+
usethis::use_directory(file.path(path, "child-docs"))
152152

153153
usethis::use_template(
154154
template = file.path(
155155
paste0("methods-", assay),
156156
paste0(assay, "-statistical-methods.Rmd")
157157
),
158158
data = list(pkg_ver = pkg_ver),
159-
save_as = file.path(path, "methods", "statistical-methods.Rmd"),
159+
save_as = file.path(path, "child-docs", "statistical-methods.Rmd"),
160160
package = "VISCtemplates"
161161
)
162162

@@ -166,7 +166,7 @@ use_visc_methods <- function(path = ".", assay = c("generic", "bama", "nab", "ad
166166
paste0(assay, "-lab-methods.Rmd")
167167
),
168168
data = list(pkg_ver = pkg_ver),
169-
save_as = file.path(path, "methods", "lab-methods.Rmd"),
169+
save_as = file.path(path, "child-docs", "lab-methods.Rmd"),
170170
package = "VISCtemplates"
171171
)
172172

@@ -176,7 +176,7 @@ use_visc_methods <- function(path = ".", assay = c("generic", "bama", "nab", "ad
176176
paste0(assay, "-biological-endpoints.Rmd")
177177
),
178178
data = list(pkg_ver = pkg_ver),
179-
save_as = file.path(path, "methods", "biological-endpoints.Rmd"),
179+
save_as = file.path(path, "child-docs", "biological-endpoints.Rmd"),
180180
package = "VISCtemplates"
181181
)
182182

inst/templates/visc_report/skeleton/skeleton.Rmd

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,17 +198,17 @@ Objectives can be found on ATLAS, in the study protocol, or in the SAP.
198198

199199
# Biological Endpoints
200200

201-
```{r biological-endpoints, child="methods/biological-endpoints.Rmd"}
201+
```{r biological-endpoints, child="child-docs/biological-endpoints.Rmd"}
202202
```
203203

204204
# Lab Methods
205205

206-
```{r lab-methods, child="methods/lab-methods.Rmd"}
206+
```{r lab-methods, child="child-docs/lab-methods.Rmd"}
207207
```
208208

209209
# Statistical Methods
210210

211-
```{r statistical-methods, child="methods/statistical-methods.Rmd"}
211+
```{r statistical-methods, child="child-docs/statistical-methods.Rmd"}
212212
```
213213

214214
```{r response-testing, warning=FALSE}

0 commit comments

Comments
 (0)