Skip to content

Commit e0f3a0a

Browse files
authored
Merge pull request #308 from FredHutch/contact_linebreaks
ensure line breaks between multiple contact personnel
2 parents 20b12c1 + 51a5654 commit e0f3a0a

File tree

4 files changed

+21
-12
lines changed

4 files changed

+21
-12
lines changed

NEWS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# VISCtemplates (development version)
22

33
Improvements for users
4+
* Line breaks added between multiple contact personnel on title page of PDF report template (#308)
45
* `visc_load_pdata()` gives more informative error message when serialized pdata file does not contain an R object of the same name (#303)
56
* Default behavior of `create_visc_project()` no longer includes creation of package-specific files DESCRIPTION and NAMESPACE (#306)
67

inst/templates/report_latex_template.tex

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,8 @@
269269
\advance\dimen@\@totalleftmargin
270270
\advance\dimen@-\dimen\@curtab
271271
\parbox[t]\dimen@{%
272-
\leftskip=2em\hspace*{-2em}#1\ifhmode\strut\fi}%
272+
\parindent=0pt % Ensure no paragraph indentation
273+
#1\ifhmode\strut\fi}%
273274
}
274275
\makeatother
275276

@@ -278,15 +279,16 @@
278279
\begin{flushleft}
279280
\begin{tabbing}
280281
this line is to\= set up the tab stop \kill
281-
{\bf Date:} \> \insertdate\\
282-
{\bf To:} \> \tabfill{$for(to)$$to.name$$sep$, $endfor$}\\
282+
{\bf Date:} \> \insertdate\\[0.5em]
283+
{\bf To:} \> \tabfill{$for(to)$$to.name$$sep$, $endfor$}\\[0.1em]
283284
{\bf From:} \> \tabfill{$for(from)$$from.name$$sep$, $endfor$}\\
284-
{\bf RE:} \> \tabfill{$title$}\\
285285
$if(dropcc)$
286+
[0.5em]
286287
$else$
287-
{\bf cc:} \> \tabfill{$for(cc)$$cc.name$$sep$, $endfor$}\\
288+
[0.1em]{\bf CC:} \> \tabfill{$for(cc)$$cc.name$$sep$, $endfor$}\\[0.5em]
288289
$endif$
289-
{\bf Contact:} \> \tabfill{$for(from)$$if(from.contact)$$from.name$, $from.email$$endif$ $endfor$}\\
290+
{\bf RE:} \> \tabfill{$title$}\\[0.5em]
291+
{\bf Contact:} \> \tabfill{$for(from)$$if(from.contact)$$from.name$ ($from.email$)\\$endif$ $endfor$}\\[0.5em]
290292
\end{tabbing}
291293
\end{flushleft}
292294

inst/templates/visc_empty/skeleton/skeleton.Rmd

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,19 @@ author: "Contact: First Name, Last Name (xxx@fredhutch.org)"
66
date: "Word document compiled on `r format(Sys.Date(), '%A, %B %d, %Y')`"
77
from:
88
- name: FirstNameA LastNameA
9-
email: foo@bar.com
9+
email: xxx@fredhutch.org
1010
contact: true
1111
- name: FirstNameB LastNameB
12-
to:
12+
email: yyy@zzz.com
13+
contact: true
1314
- name: FirstNameC LastNameC
15+
to:
1416
- name: FirstNameD LastNameD
17+
- name: FirstNameE LastNameE
1518
dropcc: false
1619
cc:
17-
- name: FirstNameE LastNameE
1820
- name: FirstNameF LastNameF
21+
- name: FirstNameG LastNameG
1922
includesummary: true
2023
summary:
2124
A short summary about your report.

inst/templates/visc_report/skeleton/skeleton.Rmd

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,19 @@ author: "Contact: First Name, Last Name (xxx@fredhutch.org)"
66
date: "Word document compiled on `r format(Sys.Date(), '%A, %B %d, %Y')`"
77
from:
88
- name: FirstNameA LastNameA
9-
email: foo@bar.com
9+
email: xxx@fredhutch.org
1010
contact: true
1111
- name: FirstNameB LastNameB
12-
to:
12+
email: yyy@zzz.com
13+
contact: true
1314
- name: FirstNameC LastNameC
15+
to:
1416
- name: FirstNameD LastNameD
17+
- name: FirstNameE LastNameE
1518
dropcc: false
1619
cc:
17-
- name: FirstNameE LastNameE
1820
- name: FirstNameF LastNameF
21+
- name: FirstNameG LastNameG
1922
includesummary: true
2023
summary:
2124
A short summary about your report.

0 commit comments

Comments
 (0)