delete useless get_cstring()

Author: Frederick888

bstr.cc

@@ -53,7 +53,8 @@ zval * bstr::to_array(const bool include_meta) const {
         char *_type_data = estrdup("bstr");
         char *_length = estrdup("_length");
         char *_data = estrdup("_data");
-        char *_data_data = zend_container::get_cstring(_value);
+        char *_data_data = (char*)emalloc(_value.length() + 1);
+        strcpy(_data_data, _value.c_str());
         add_assoc_string(zv, _type, _type_data);
         add_assoc_long(zv, _length, length());
         add_assoc_string(zv, _data, _data_data);
@@ -63,9 +64,10 @@ zval * bstr::to_array(const bool include_meta) const {
         efree(_data);
         efree(_data_data);
     } else {
-        char *tmp = zend_container::get_cstring(_value);
-        ZVAL_STRING(zv, tmp);
-        efree(tmp);
+        char *_data_data = (char *)emalloc(_value.length() + 1);
+        strcpy(_data_data, _value.c_str());
+        ZVAL_STRING(zv, _data_data);
+        efree(_data_data);
     }
     return zv;
 }

zend_container.h

@@ -54,11 +54,6 @@ class zend_container {
         ZVAL_OBJ(new_object, Z_OBJ_P(object)->handlers->clone_obj(object));
         return Z_OBJ_P(new_object);
     }
-    static char * get_cstring(std::string cppstring) {
-        char *result = (char *)emalloc(cppstring.length() + 1);
-        strcpy(result, cppstring.c_str());
-        return result;
-    }
 };
 
 #endif