code cleaning

Author: Frederick888

bdict.cc

@@ -186,8 +186,7 @@ size_t bdict::count() const {
 zval * bdict::parse(const std::string &ben, size_t &pt) {
     if (ben[pt] != 'd')
         return bitem::throw_general_exception("Error parsing bdict");
-    zval _zv;
-    zval *zv = &_zv;
+    zval *zv = new zval();
     zend_object *zo = zend_container::bdict_object_new(zend_container::bdict_ce);
     ZVAL_OBJ(zv, zo);
     bdict_object *intern = zend_container::bdict_fetch_object(Z_OBJ_P(zv));
@@ -248,8 +247,7 @@ std::string bdict::encode() const {
 }
 
 zval * bdict::to_array(const bool include_meta) const {
-    zval _zv;
-    zval *zv = &_zv;
+    zval *zv = new zval();
     array_init(zv);
 
     for(zend_hash_internal_pointer_reset(_data);
@@ -287,8 +285,7 @@ zval * bdict::to_array(const bool include_meta) const {
         char *_type_data = estrdup("bdict");
         char *_length = estrdup("_length");
         char *_data = estrdup("_data");
-        zval _zv_outer;
-        zval *zv_outer = &_zv_outer;
+        zval *zv_outer = new zval();
         array_init(zv_outer);
         add_assoc_string(zv_outer, _type, _type_data);
         add_assoc_long(zv_outer, _length, length());
@@ -311,8 +308,7 @@ zval * bdict::search(const std::string &needle, const long &mode, const std::str
     else
         modev = true;
 
-    zval _zv;
-    zval *zv = &_zv;
+    zval *zv = new zval();
     array_init(zv);
 
     for(zend_hash_internal_pointer_reset(_data);

bint.cc

@@ -33,8 +33,7 @@ zval * bint::parse(const std::string &ben, size_t &pt) {
     long result = std::stoll(strint);
     ++pt;
 
-    zval _zv;
-    zval *zv = &_zv;
+    zval *zv = new zval();
     zend_object *zo = zend_container::bint_object_new(zend_container::bint_ce);
     ZVAL_OBJ(zv, zo);
     bint_object *intern = zend_container::bint_fetch_object(Z_OBJ_P(zv));
@@ -47,8 +46,7 @@ std::string bint::encode() const {
 }
 
 zval * bint::to_array(const bool include_meta) const {
-    zval _zv;
-    zval *zv = &_zv;
+    zval *zv = new zval();
     if (include_meta) {
         array_init(zv);
         char *_type = estrdup("_type");

bitem.cc

@@ -12,8 +12,7 @@ zval * bitem::throw_general_exception(const std::string message) {
 }
 
 zval * bitem::get_zval_bool(const bool value) {
-    zval _zv;
-    zval *zv = &_zv;
+    zval *zv = new zval();
     ZVAL_BOOL(zv, value);
     return zv;
 }
@@ -90,8 +89,7 @@ zval * bitem::load(const std::string &file_path) {
     std::string ben((std::istreambuf_iterator<char>(ben_file)),
             (std::istreambuf_iterator<char>()));
     ben_file.close();
-    zval _result = *parse(ben);
-    zval *result = &_result;
+    zval *result = parse(ben);
     return result;
 }
 

blist.cc

@@ -225,8 +225,7 @@ zval * blist::parse(const std::string &ben, size_t &pt) {
     if (ben[pt] != 'l')
         return bitem::throw_general_exception("Error parsing blist");
     ++pt;
-    zval _zv;
-    zval *zv = &_zv;
+    zval *zv = new zval();
     zend_object *zo = zend_container::blist_object_new(zend_container::blist_ce);
     ZVAL_OBJ(zv, zo);
     blist_object *intern = zend_container::blist_fetch_object(Z_OBJ_P(zv));
@@ -275,8 +274,7 @@ std::string blist::encode() const {
 }
 
 zval * blist::to_array(const bool include_meta) const {
-    zval _zv;
-    zval *zv = &_zv;
+    zval *zv = new zval();
     array_init(zv);
 
     for(zend_hash_internal_pointer_reset(_data);
@@ -308,8 +306,7 @@ zval * blist::to_array(const bool include_meta) const {
         char *_type_data = estrdup("blist");
         char *_length = estrdup("_length");
         char *_data = estrdup("_data");
-        zval _zv_outer;
-        zval *zv_outer = &_zv_outer;
+        zval *zv_outer = new zval();
         array_init(zv_outer);
         add_assoc_string(zv_outer, _type, _type_data);
         add_assoc_long(zv_outer, _length, length());
@@ -332,8 +329,7 @@ zval * blist::search(const std::string &needle, const long &mode, const std::str
     else
         modev = true;
 
-    zval _zv;
-    zval *zv = &_zv;
+    zval *zv = new zval();
     array_init(zv);
 
     for(zend_hash_internal_pointer_reset(_data);

bstr.cc

@@ -31,8 +31,7 @@ zval * bstr::parse(const std::string &ben, size_t &pt) {
     std::string len = ben.substr(start, pt - start);
     ++pt;
 
-    zval _zv;
-    zval *zv = &_zv;
+    zval *zv = new zval();
     zend_object *zo = zend_container::bstr_object_new(zend_container::bstr_ce);
     ZVAL_OBJ(zv, zo);
     bstr_object *intern = zend_container::bstr_fetch_object(Z_OBJ_P(zv));
@@ -46,8 +45,7 @@ std::string bstr::encode() const {
 }
 
 zval * bstr::to_array(const bool include_meta) const {
-    zval _zv;
-    zval *zv = &_zv;
+    zval *zv = new zval();
     if (include_meta) {
         array_init(zv);
         if (_value.length() == 0) return zv;