Skip to content

Commit d54592a

Browse files
authored
Fix default mode set KV V2 bug (#19)
* Fix default mode set KV V2 bug * Apply Code Coverage Badge --------- Co-authored-by: edocsss <[email protected]>
1 parent 83a3c9b commit d54592a

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
![Unit Test](https://github.com/FreeLeh/GoFreeDB/actions/workflows/unit_test.yml/badge.svg)
2121
![Integration Test](https://github.com/FreeLeh/GoFreeDB/actions/workflows/full_test.yml/badge.svg)
22-
![Coverage](https://img.shields.io/badge/Coverage-82.8%25-brightgreen)
22+
![Coverage](https://img.shields.io/badge/Coverage-83.0%25-brightgreen)
2323
[![Go Report Card](https://goreportcard.com/badge/github.com/FreeLeh/GoFreeDB)](https://goreportcard.com/report/github.com/FreeLeh/GoFreeDB)
2424
[![Go Reference](https://pkg.go.dev/badge/github.com/FreeLeh/GoFreeDB.svg)](https://pkg.go.dev/github.com/FreeLeh/GoFreeDB)
2525

internal/google/store/kv_v2.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package store
33
import (
44
"context"
55
"fmt"
6+
67
"github.com/FreeLeh/GoFreeDB/internal/codec"
78
"github.com/FreeLeh/GoFreeDB/internal/google/sheets"
89
"github.com/FreeLeh/GoFreeDB/internal/models"
@@ -67,6 +68,14 @@ func (s *GoogleSheetKVStoreV2) Set(ctx context.Context, key string, value []byte
6768
return err
6869
}
6970

71+
if s.mode == models.KVModeDefault {
72+
if err := s.rowStore.Delete().
73+
Where("key = ?", key).
74+
Exec(ctx); err != nil {
75+
return err
76+
}
77+
}
78+
7079
row := googleSheetKVStoreV2Row{
7180
Key: key,
7281
Value: encoded,

internal/google/store/kv_v2_test.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ package store
33
import (
44
"context"
55
"fmt"
6-
"github.com/FreeLeh/GoFreeDB/internal/common"
7-
"github.com/FreeLeh/GoFreeDB/internal/models"
86
"testing"
97
"time"
108

9+
"github.com/FreeLeh/GoFreeDB/internal/common"
10+
"github.com/FreeLeh/GoFreeDB/internal/models"
11+
1112
"github.com/FreeLeh/GoFreeDB/google/auth"
1213
"github.com/stretchr/testify/assert"
1314
)
@@ -102,6 +103,11 @@ func TestNewGoogleSheetKVStoreV2_Default_Integration(t *testing.T) {
102103
err = kv.Set(context.Background(), "k1", []byte("test2"))
103104
assert.Nil(t, err)
104105

106+
time.Sleep(time.Second)
107+
value, err = kv.Get(context.Background(), "k1")
108+
assert.Equal(t, []byte("test2"), value)
109+
assert.Nil(t, err)
110+
105111
time.Sleep(time.Second)
106112
err = kv.Delete(context.Background(), "k1")
107113
assert.Nil(t, err)

0 commit comments

Comments
 (0)