Size of NodeId(255), 2 or 4?

[pinterior]

$ python
Python 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from asyncua.ua.uatypes import NodeId
>>> NodeId(255)
NodeId(Identifier=255, NamespaceIndex=0, NodeIdType=<NodeIdType.FourByte: 1>)
>>> NodeId(255).to_binary()
b'\x01\x00\xff\x00'

should it be NodeIdType.TwoByte and b'\x00\xff' ?

(also, NodeId(0, 255) should be NodeIdType.FourByte instead of NodeIdType.Numeric i think)

[schroeder-]

The first two bytes signal which nodeidtype is used.

[pinterior]

255 is representable in Two Byte NodeId, but if no NodeIdType is specified, NodeIdType.FourByte is automatically selected.
i think both < 255 below should be < 256 if the behavior is not intended.

opcua-asyncio/asyncua/ua/uatypes.py

Lines 456 to 464 in e9978c1

	def __post_init__(self):
	if self.NodeIdType is None:
	if isinstance(self.Identifier, int):
	if self.Identifier < 255 and self.NamespaceIndex == 0:
	object.__setattr__(self, "NodeIdType", NodeIdType.TwoByte)
	elif self.Identifier < 2 ** 16 and self.NamespaceIndex < 255:
	object.__setattr__(self, "NodeIdType", NodeIdType.FourByte)
	else:
	object.__setattr__(self, "NodeIdType", NodeIdType.Numeric)

[schroeder-]

Yeah it should be 256