minor cleanups in thread code

Author: alandekok

src/lib/io/schedule.c

@@ -121,7 +121,6 @@ static void *fr_schedule_worker_thread(void *arg)
 	fr_schedule_worker_t		*sw = talloc_get_type_abort(arg, fr_schedule_worker_t);
 	fr_schedule_t			*sc = sw->sc;
 	fr_thread_status_t		status = FR_THREAD_FAIL;
-	fr_schedule_network_t		*sn;
 	char				worker_name[32];
 
 	worker_id = sw->thread.id;		/* Store the current worker ID */
@@ -157,9 +156,7 @@ static void *fr_schedule_worker_thread(void *arg)
 	/*
 	 *	Add this worker to all network threads.
 	 */
-	for (sn = fr_dlist_head(&sc->networks);
-	     sn != NULL;
-	     sn = fr_dlist_next(&sc->networks, sn)) {
+	fr_dlist_foreach(&sc->networks, fr_schedule_network_t, sn) {
 		if (unlikely(fr_network_worker_add(sn->nr, sw->worker) < 0)) {
 			PERROR("%s - Failed adding worker to network %u", worker_name, sn->thread.id);
 			goto fail;	/* FIXME - Should maybe try to undo partial adds? */
@@ -217,8 +214,6 @@ static void *fr_schedule_network_thread(void *arg)
 
 	if (fr_thread_setup(&sn->thread, network_name) < 0) goto fail;
 
-	INFO("%s - Starting", network_name);
-
 	sn->nr = fr_network_create(sn->thread.ctx, sn->thread.el, network_name, sc->log, sc->lvl, &sc->config->network);
 	if (!sn->nr) {
 		PERROR("%s - Failed creating network", network_name);

src/lib/io/thread.c

@@ -114,6 +114,8 @@ int fr_thread_setup(fr_thread_t *out, char const *name)
 	TALLOC_CTX	*ctx;
 	fr_event_list_t	*el;
 
+	out->name = name;
+
 #ifndef __APPLE__
 	/*
 	 *	OSX doesn't use pthread_signmask in its setcontext
@@ -146,7 +148,6 @@ int fr_thread_setup(fr_thread_t *out, char const *name)
 	 *	Do NOT initialize the entire structure.  Fields like "id" and "entry" have already been
 	 *	initialize and used by the main thread coordinator.
 	 */
-	out->name = name;
 	out->ctx = ctx;
 	out->el = el;
 	out->status = FR_THREAD_INITIALIZING;
@@ -217,6 +218,11 @@ void fr_thread_start(fr_thread_t *thread, fr_sem_t *sem)
  */
 void fr_thread_exit(fr_thread_t *thread, fr_thread_status_t status, fr_sem_t *sem)
 {
+	/*
+	 *	Maybe nothing was initialized, so we don't need to do anything.
+	 */
+	if (thread->status == FR_THREAD_FREE) return;
+
 	INFO("%s - Exiting", thread->name);
 
 	thread->status = status;