ensure that unknown DA's aren't parented from the NULL ctx

and add assertion to that effect in the dictionary ext handler.

This avoids memory leaks when the callers aren't careful about
passing in the correct ctx.

Author: alandekok

src/lib/server/tmpl_eval.c

@@ -1459,8 +1459,6 @@ static int _tmpl_global_free(UNUSED void *uctx)
 {
 	fr_dict_autofree(tmpl_dict);
 
-	fr_dict_attr_unknown_free(&tmpl_attr_unspec);
-
 	return 0;
 }
 
@@ -1473,7 +1471,7 @@ static int _tmpl_global_init(UNUSED void *uctx)
 		return -1;
 	}
 
-	da = fr_dict_attr_unknown_raw_afrom_num(NULL, fr_dict_root(dict_freeradius), 0);
+	da = fr_dict_attr_unknown_raw_afrom_num(UNCONST(TALLOC_CTX *, dict_freeradius), fr_dict_root(dict_freeradius), 0);
 	fr_assert(da != NULL);
 
 	da->type = FR_TYPE_NULL;

src/lib/server/tmpl_tokenize.c

@@ -1956,6 +1956,8 @@ static inline int tmpl_attr_afrom_attr_substr(TALLOC_CTX *ctx, tmpl_attr_error_t
 	if (fr_sbuff_out(NULL, &oid, name) > 0) {
 		namespace = fr_dict_unlocal(namespace);
 
+		fr_assert(ar == NULL);
+
 		fr_strerror_clear();	/* Clear out any existing errors */
 
 		if (fr_dict_by_da(namespace) == fr_dict_internal()) goto disallow_unknown;
@@ -1981,6 +1983,7 @@ static inline int tmpl_attr_afrom_attr_substr(TALLOC_CTX *ctx, tmpl_attr_error_t
 		 *      then we create an unknown attribute with
 		 *	the specified attribute number.
 		 */
+		MEM(ar = talloc(ctx, tmpl_attr_t));
 
 		/*
 		 *	VSAs have VENDORs as children.  All others are just normal things.
@@ -2000,7 +2003,6 @@ static inline int tmpl_attr_afrom_attr_substr(TALLOC_CTX *ctx, tmpl_attr_error_t
 			goto error;
 		}
 
-		MEM(ar = talloc(ctx, tmpl_attr_t));
 		*ar = (tmpl_attr_t){
 			.ar_num = NUM_UNSPEC,
 			.ar_type = TMPL_ATTR_TYPE_UNKNOWN,

src/lib/util/ext.c

@@ -66,6 +66,9 @@ void *fr_ext_alloc_size(fr_ext_t const *def, void **chunk_p, int ext, size_t ext
 	uint8_t			*ext_ptr;
 	char const		*type;
 
+	fr_assert(chunk != NULL);
+	fr_assert(talloc_parent(chunk) != NULL);
+
 	ext_offsets = fr_ext_offsets(def, *chunk_p);
 	if (ext_offsets[ext]) return fr_ext_ptr(*chunk_p, ext_offsets[ext], info->has_hdr);
 

src/lib/util/pair_legacy.c

@@ -344,7 +344,7 @@ fr_slen_t fr_pair_list_afrom_substr(fr_pair_parse_t const *root, fr_pair_parse_t
 					}
 				}
 
-				slen = fr_dict_attr_unknown_afrom_oid_substr(NULL, &da_unknown, relative->da, &our_in, raw_type);
+				slen = fr_dict_attr_unknown_afrom_oid_substr(root->ctx, &da_unknown, relative->da, &our_in, raw_type);
 				if (slen < 0) return fr_sbuff_error(&our_in) + slen;
 
 				fr_assert(da_unknown);
@@ -454,7 +454,7 @@ fr_slen_t fr_pair_list_afrom_substr(fr_pair_parse_t const *root, fr_pair_parse_t
 				return fr_sbuff_error(&our_in);
 			}
 
-			da_unknown = fr_dict_attr_unknown_raw_afrom_da(NULL, da);
+			da_unknown = fr_dict_attr_unknown_raw_afrom_da(root->ctx, da);
 			if (!da_unknown) return fr_sbuff_error(&our_in);
 
 			fr_assert(da_unknown->type == FR_TYPE_OCTETS);