minimal changes to get rid of tmpl_require_enum_prefix

all of the tests pass with it enabled.  So let's require it.

If CI passes, we'll take a second pass and remove all references
to it from the code.

Author: alandekok

src/bin/unit_test_attribute.c

@@ -2394,7 +2394,7 @@ static size_t command_max_buffer_size(command_result_t *result, command_file_ctx
 	RETURN_OK(snprintf(data, COMMAND_OUTPUT_MAX, "%ld", size));
 }
 
-extern bool tmpl_require_enum_prefix;
+//extern bool tmpl_require_enum_prefix;
 extern bool xlat_func_bare_words;
 
 /** Set or clear migration flags.
@@ -2415,7 +2415,8 @@ static size_t command_migrate(command_result_t *result, command_file_ctx_t *cc,
 
 	} else if (strncmp(p, "tmpl_require_enum_prefix", sizeof("tmpl_require_enum_prefix") - 1) == 0) {
 		p += sizeof("tmpl_require_enum_prefix") - 1;
-		out = &tmpl_require_enum_prefix;
+//		out = &tmpl_require_enum_prefix;
+		RETURN_OK(0);
 
 	} else {
 		fr_strerror_const("Unknown migration flag");
@@ -3844,7 +3845,7 @@ int main(int argc, char *argv[])
 
 		case 'S':
 			if (strcmp(optarg, "require_enum_prefix=yes") == 0) {
-				tmpl_require_enum_prefix = true;
+//				tmpl_require_enum_prefix = true;
 				break;
 			}
 

src/lib/server/cf_parse.c

@@ -50,7 +50,7 @@ static char const parse_spaces[] = "
 /*
  *	For migration.
  */
-extern bool tmpl_require_enum_prefix;
+//extern bool tmpl_require_enum_prefix;
 
 void cf_pair_debug_log(CONF_SECTION const *cs, CONF_PAIR *cp, conf_parser_t const *rule)
 {

src/lib/server/main_config.c

@@ -187,7 +187,7 @@ static const conf_parser_t thread_config[] = {
 /*
  *	Migration configuration.
  */
-extern bool tmpl_require_enum_prefix;
+//extern bool tmpl_require_enum_prefix;
 bool xlat_func_bare_words = false;
 
 static const conf_parser_t migrate_config[] = {
@@ -1541,7 +1541,7 @@ int main_config_parse_option(char const *value)
 		fr_exit(1);
 	}
 
-	if (out == &main_config->require_enum_prefix) tmpl_require_enum_prefix = box.vb_bool;
+	if (out == &main_config->require_enum_prefix) {}
 	if (out == &main_config->xlat_func_bare_words) xlat_func_bare_words = box.vb_bool;
 
 	*out = box.vb_bool;

src/lib/server/map.c

@@ -47,7 +47,7 @@ RCSID("$Id$")
 
 #include <ctype.h>
 
-extern bool tmpl_require_enum_prefix;
+//extern bool tmpl_require_enum_prefix;
 
 static fr_table_num_sorted_t const cond_quote_table[] = {
 	{ L("\""),	T_DOUBLE_QUOTED_STRING	},	/* Don't re-order, backslash throws off ordering */

src/lib/server/tmpl.h

@@ -84,6 +84,8 @@ extern "C" {
  */
 #define TMPL_MAX_REQUEST_REF_NESTING	10
 
+#define tmpl_require_enum_prefix (1)
+
 extern fr_table_num_ordered_t const pair_list_table[];
 extern size_t pair_list_table_len;
 

src/lib/server/tmpl_tokenize.c

@@ -49,9 +49,9 @@ RCSID("$Id$")
 /*
  *	Migration flag for enum prefixes.
  */
-extern bool tmpl_require_enum_prefix;
+//extern bool tmpl_require_enum_prefix;
 
-bool tmpl_require_enum_prefix = true;
+//bool tmpl_require_enum_prefix = true;
 
 /** Define a global variable for specifying a default request reference
  *

src/lib/unlang/compile.c

@@ -61,7 +61,7 @@ RCSID("$Id$")
 
 #define UNLANG_IGNORE ((unlang_t *) -1)
 
-extern bool tmpl_require_enum_prefix;
+//extern bool tmpl_require_enum_prefix;
 
 static unsigned int unlang_number = 1;
 

src/lib/unlang/xlat_expr.c

@@ -39,7 +39,7 @@ RCSID("$Id$")
 #  define XLAT_DEBUG(...)
 #endif
 
-extern bool tmpl_require_enum_prefix;
+//extern bool tmpl_require_enum_prefix;
 
 /*
  *	The new tokenizer accepts most things which are accepted by the old one.  Many of the errors will be

src/lib/unlang/xlat_tokenize.c

@@ -45,7 +45,7 @@ RCSID("$Id$")
 #  define XLAT_HEXDUMP(...)
 #endif
 
-extern const bool tmpl_require_enum_prefix;
+//extern const bool tmpl_require_enum_prefix;
 extern const bool xlat_func_bare_words;
 
 /** These rules apply to literal values and function arguments inside of an expansion