Skip to content

Commit 939aeb8

Browse files
committed
set variables to NULL on free
and goto correct cleanup path
1 parent cd5dff0 commit 939aeb8

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/lib/tls/cache.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1491,6 +1491,7 @@ int fr_tls_cache_ctx_init(SSL_CTX *ctx, fr_tls_cache_conf_t const *cache_conf)
14911491
goto kdf_error;
14921492
}
14931493
EVP_PKEY_CTX_free(pkey_ctx);
1494+
pkey_ctx = NULL;
14941495

14951496
fr_assert(talloc_array_length(key_buff) == key_len);
14961497

@@ -1506,7 +1507,7 @@ int fr_tls_cache_ctx_init(SSL_CTX *ctx, fr_tls_cache_conf_t const *cache_conf)
15061507

15071508
DEBUG3("Derived session-ticket-key:");
15081509
HEXDUMP3(key_buff, key_len, NULL);
1509-
talloc_free(key_buff);
1510+
TALLOC_FREE(key_buff);
15101511

15111512
/*
15121513
* These callbacks embed and extract the
@@ -1518,7 +1519,7 @@ int fr_tls_cache_ctx_init(SSL_CTX *ctx, fr_tls_cache_conf_t const *cache_conf)
15181519
UNCONST(fr_tls_cache_conf_t *, cache_conf)) != 1)) {
15191520
fr_tls_strerror_printf(NULL);
15201521
PERROR("Failed setting session ticket callbacks");
1521-
goto key_buff_error;
1522+
goto kdf_error;
15221523
}
15231524

15241525
/*

0 commit comments

Comments
 (0)