return code (-1) when invalid data type

czp182 · alandekok · commit de3c4c286b62 · 2026-03-07T07:48:07.000-05:00
(value.c: fr_value_box_ipaddr_from_network returns 0 instead of -1 for invalid type 302)
diff --git a/src/lib/util/value.c b/src/lib/util/value.c
@@ -2337,7 +2337,7 @@ ssize_t fr_value_box_ipaddr_from_network(fr_value_box_t *dst, fr_type_t type, fr
 	default:
 		fr_strerror_printf("Invalid data type '%s' passed to IP address decode function",
 				   fr_type_to_str(type));
-		return 0;
+		return -1;
 	}
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -2337,7 +2337,7 @@ ssize_t fr_value_box_ipaddr_from_network(fr_value_box_t *dst, fr_type_t type, fr`
`2337`	`2337`	`default:`
`2338`	`2338`	`fr_strerror_printf("Invalid data type '%s' passed to IP address decode function",`
`2339`	`2339`	`fr_type_to_str(type));`
`2340`		`- return 0;`
	`2340`	`+ return -1;`
`2341`	`2341`	`}`
`2342`	`2342`
`2343`	`2343`	`/*`