Skip to content

Commit e9085ac

Browse files
committed
use DER types, now that we can use the DER names
1 parent 86160f3 commit e9085ac

File tree

6 files changed

+44
-34
lines changed

6 files changed

+44
-34
lines changed

share/dictionary/der/dictionary

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,16 @@
99
#
1010
BEGIN PROTOCOL DER 11354911
1111

12+
#
13+
# Note that the data types for DER are local to DER!
14+
#
15+
# * `integer` is packed as 1, 2, or more bytes, depending on its size.
16+
# The server manages all DER numbers as `int64`.
17+
#
18+
# * `null` is an empty value.
19+
# The server manages all DER `null` as `bool`.
20+
#
21+
1222
$INCLUDE dictionary.common
1323
$INCLUDE dictionary.oids
1424
$INCLUDE dictionary.rfc2986

share/dictionary/der/dictionary.common

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ BEGIN GeneralName
77

88
ATTRIBUTE otherName 0 sequence option=0
99
BEGIN otherName
10-
DEFINE type-id string der_type=oid
11-
DEFINE Value-thing tlv der_type=sequence,class=context-specific,tagnum=0
10+
DEFINE type-id oid
11+
DEFINE Value-thing sequence class=context-specific,tagnum=0
1212
BEGIN Value-thing
13-
DEFINE userPrincipalName string der_type=utf8string
13+
DEFINE userPrincipalName utf8string
1414
END Value-thing
1515
END otherName
1616

@@ -42,9 +42,9 @@ END DirectoryName
4242
DEFINE GeneralSubtree sequence
4343
BEGIN GeneralSubtree
4444
DEFINE base sequence clone=GeneralName
45-
DEFINE minimum int64 option=0,has_default
45+
DEFINE minimum integer option=0,has_default
4646
VALUE minimum DEFAULT 0
47-
DEFINE maximum int64 option=1
47+
DEFINE maximum integer option=1
4848
END GeneralSubtree
4949

5050
DEFINE Name sequence

share/dictionary/der/dictionary.extensions

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ DEFINE accessLocation choice
1414
BEGIN accessLocation
1515
ATTRIBUTE otherName 0 sequence option=0
1616
BEGIN otherName
17-
DEFINE type-id string der_type=oid
18-
DEFINE Value-thing tlv der_type=sequence,class=context-specific,tagnum=0
17+
DEFINE type-id oid
18+
DEFINE Value-thing sequence class=context-specific,tagnum=0
1919
BEGIN Value-thing
20-
DEFINE userPrincipalName string der_type=utf8string
20+
DEFINE userPrincipalName utf8string
2121
END Value-thing
2222
END otherName
2323

@@ -40,10 +40,10 @@ DEFINE accessLocation choice
4040
BEGIN accessLocation
4141
ATTRIBUTE otherName 0 sequence option=0
4242
BEGIN otherName
43-
DEFINE type-id string der_type=oid
44-
DEFINE Value-thing tlv der_type=sequence,class=context-specific,tagnum=0
43+
DEFINE type-id oid
44+
DEFINE Value-thing sequence class=context-specific,tagnum=0
4545
BEGIN Value-thing
46-
DEFINE userPrincipalName string der_type=utf8string
46+
DEFINE userPrincipalName utf8string
4747
END Value-thing
4848
END otherName
4949

@@ -78,7 +78,7 @@ ATTRIBUTE basicConstraints 2.5.29.19 sequence is_oid_leaf
7878
BEGIN 2.5.29.19
7979
DEFINE cA boolean has_default
8080
VALUE cA DEFAULT false
81-
DEFINE pathLenConstraint int64
81+
DEFINE pathLenConstraint integer
8282
END 2.5.29.19
8383

8484
ATTRIBUTE nameConstraints 2.5.29.30 sequence is_oid_leaf
@@ -96,7 +96,7 @@ BEGIN distributionPointName
9696
ATTRIBUTE fullName 0 group ref=GeneralName,der_type=sequence,sequence_of=choice,option=0
9797
ATTRIBUTE nameRelativeToCRLIssuer 1 sequence option=1
9898
BEGIN nameRelativeToCRLIssuer
99-
DEFINE RelativeDistinguishedName tlv der_type=set
99+
DEFINE RelativeDistinguishedName set
100100
BEGIN RelativeDistinguishedName
101101
DEFINE AttributeTypeandValue group ref=OID-Tree,is_pair
102102
END RelativeDistinguishedName
@@ -168,7 +168,7 @@ BEGIN distributionPointName
168168
ATTRIBUTE fullName 0 group ref=GeneralName,der_type=sequence,sequence_of=choice,option=0
169169
ATTRIBUTE nameRelativeToCRLIssuer 1 sequence option=1
170170
BEGIN nameRelativeToCRLIssuer
171-
DEFINE RelativeDistinguishedName tlv der_type=set
171+
DEFINE RelativeDistinguishedName set
172172
BEGIN RelativeDistinguishedName
173173
DEFINE AttributeTypeandValue group ref=OID-Tree,is_pair
174174
END RelativeDistinguishedName
@@ -192,4 +192,4 @@ DEFINE cRLIssuer group ref=GeneralName,der_type=sequence,sequence_of=choic
192192

193193
END distributionPoint
194194

195-
ATTRIBUTE inhibitAnyPolicy 2.5.29.54 int64 is_oid_leaf
195+
ATTRIBUTE inhibitAnyPolicy 2.5.29.54 integer is_oid_leaf

share/dictionary/der/dictionary.oids

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ VALUE 1.2.840.10045.4.3.3 DEFAULT false
1919
ATTRIBUTE rsadsi 1.2.840.113549 tlv
2020
ATTRIBUTE pkcs 1.2.840.113549.1 tlv
2121
ATTRIBUTE pkcs-1 1.2.840.113549.1.1 tlv
22-
ATTRIBUTE rsaEncryption 1.2.840.113549.1.1.1 bool is_oid_leaf,der_type=null
22+
ATTRIBUTE rsaEncryption 1.2.840.113549.1.1.1 null is_oid_leaf
2323

24-
ATTRIBUTE sha256WithRSAEncryption 1.2.840.113549.1.1.11 bool is_oid_leaf,der_type=null
24+
ATTRIBUTE sha256WithRSAEncryption 1.2.840.113549.1.1.11 null is_oid_leaf
2525

2626
ATTRIBUTE identified-organization 1.3 tlv
2727
ATTRIBUTE dod 1.3.6 tlv

share/dictionary/der/dictionary.rfc2986

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,16 @@ BEGIN CertificateRequest
77

88
DEFINE certificationRequestInfo tlv
99
BEGIN certificationRequestInfo
10-
DEFINE version int64
10+
DEFINE version integer
1111

1212
DEFINE subject tlv
1313
BEGIN subject
14-
DEFINE RelativeDistinguishedName tlv der_type=set
14+
DEFINE RelativeDistinguishedName set
1515
BEGIN RelativeDistinguishedName
1616
DEFINE AttributeTypeandValue tlv
1717
BEGIN AttributeTypeAndValue
18-
DEFINE OID string der_type=oid
19-
DEFINE Value-Thing string der_type=utf8string
18+
DEFINE OID oid
19+
DEFINE Value-Thing utf8string
2020
END AttributeTypeAndValue
2121
END RelativeDistinguishedName
2222
END subject
@@ -25,16 +25,16 @@ DEFINE subjectPublicKeyInfo tlv
2525
BEGIN subjectPublicKeyInfo
2626
DEFINE algorithm tlv
2727
BEGIN algorithm
28-
DEFINE OID string der_type=oid
28+
DEFINE OID oid
2929
END algorithm
30-
DEFINE subjectPublicKey octets der_type=bitstring
30+
DEFINE subjectPublicKey bitstring
3131
END subjectPublicKeyInfo
3232

33-
DEFINE Attributes tlv class=context-specific,tagnum=0,der_type=sequence
33+
DEFINE Attributes sequence class=context-specific,tagnum=0
3434
BEGIN Attributes
3535
DEFINE Attribute-thing tlv
3636
BEGIN Attribute-thing
37-
DEFINE OID string der_type=oid
37+
DEFINE OID oid
3838
DEFINE Extensions group ref=OID-Tree,der_type=set,is_extensions
3939
END Attribute-thing
4040
END Attributes
@@ -43,8 +43,8 @@ END certificationRequestInfo
4343

4444
DEFINE signatureAlgorithm tlv
4545
BEGIN signatureAlgorithm
46-
DEFINE OID string der_type=oid
46+
DEFINE OID oid
4747
END signatureAlgorithm
4848

49-
DEFINE signature octets der_type=bitstring
49+
DEFINE signature bitstring
5050
END CertificateRequest

share/dictionary/der/dictionary.rfc5280

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,16 @@ BEGIN Certificate
77

88
DEFINE tbsCertificate tlv
99
BEGIN tbsCertificate
10-
DEFINE version tlv class=context-specific,tagnum=0,der_type=sequence
10+
DEFINE version sequence class=context-specific,tagnum=0
1111
BEGIN version
12-
DEFINE VersionNum int64
12+
DEFINE VersionNum integer
1313
END version
1414
DEFINE serialNumber octets tagnum=2
1515
DEFINE signature group ref=OID-Tree,is_pair
1616

17-
DEFINE issuer tlv der_type=sequence,sequence_of=set,is_pairs
17+
DEFINE issuer sequence sequence_of=set,is_pairs
1818
BEGIN issuer
19-
DEFINE RelativeDistinguishedName tlv der_type=set
19+
DEFINE RelativeDistinguishedName set
2020
BEGIN RelativeDistinguishedName
2121
DEFINE AttributeTypeAndValue group ref=OID-Tree,is_pair
2222
END RelativeDistinguishedName
@@ -30,7 +30,7 @@ END validity
3030

3131
DEFINE subject tlv sequence_of=set,is_pairs
3232
BEGIN subject
33-
DEFINE RelativeDistinguishedName tlv der_type=set
33+
DEFINE RelativeDistinguishedName set
3434
BEGIN RelativeDistinguishedName
3535
DEFINE AttributeTypeandValue group ref=OID-Tree,is_pair
3636
END RelativeDistinguishedName
@@ -39,7 +39,7 @@ END subject
3939
DEFINE subjectPublicKeyInfo tlv
4040
BEGIN subjectPublicKeyInfo
4141
DEFINE algorithm group ref=OID-Tree,is_pair
42-
DEFINE subjectPublicKey octets der_type=bitstring
42+
DEFINE subjectPublicKey bitstring
4343
END subjectPublicKeyInfo
4444

4545
DEFINE extensions x509_extensions ref=OID-Tree
@@ -48,5 +48,5 @@ END tbsCertificate
4848

4949
DEFINE signatureAlgorithm group ref=OID-Tree,is_pair
5050

51-
DEFINE signature octets der_type=bitstring
51+
DEFINE signature bitstring
5252
END Certificate

0 commit comments

Comments
 (0)