Don't suspend scheduler if task already notified #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Contributor
Author
|
No worries if you don't want to merge this. It took the same amount of time to make the PR as to ask if you would be interested in it. |
aggarg
reviewed
Nov 12, 2024
Member
|
This seems a reasonable optimization. Thank you @jefftenney ! |
|
aggarg
approved these changes
Nov 12, 2024
kar-rahul-aws
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply a small optimization to recent changes to
xTaskNotifyWait()andulTaskNotifyTake(). Prior to this PR, these functions suspend and resume the scheduler for all executions. After this PR, these functions suspend the scheduler only if the task is not already notified, and only if the caller is willing to wait for the notification.Checklist:
Related Issue
Prior to #833, these functions never suspended the scheduler but used a critical section only. After #833, these functions suspended the scheduler but only as needed (eg, the task wasn't already notified). Then #982 cleaned up the implementation but also resulted in suspending the scheduler for every call to these functions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.