Address review comments

Author: tony-josi-aws

source/portable/NetworkInterface/WinPCap/NetworkInterface.c

@@ -980,5 +980,5 @@ size_t uxNetworkInterfaceAllocateRAMToBuffers( NetworkBufferDescriptor_t pxNetwo
         }
     }
 
-    return( BUFFER_SIZE_ROUNDED_UP - BUFFER_SIZE_ROUNDED_UP );
+    return( BUFFER_SIZE_ROUNDED_UP - ipBUFFER_PADDING );
 }

source/portable/NetworkInterface/board_family/NetworkInterface.c

@@ -67,6 +67,7 @@ BaseType_t xNetworkInterfaceOutput( NetworkBufferDescriptor_t * const pxNetworkB
 size_t uxNetworkInterfaceAllocateRAMToBuffers( NetworkBufferDescriptor_t pxNetworkBuffers[ ipconfigNUM_NETWORK_BUFFER_DESCRIPTORS ] )
 {
     /* FIX ME. */
+    return 0;
 }
 
 BaseType_t xGetPhyLinkStatus( void )

test/cbmc/proofs/ARP/ARP_OutputARPRequest_buffer_alloc1/OutputARPRequest_harness.c

@@ -34,12 +34,11 @@ size_t uxNetworkInterfaceAllocateRAMToBuffers( NetworkBufferDescriptor_t pxNetwo
      *  configASSERT( ( uxMaxNetworkInterfaceAllocatedSizeBytes >= ( ipconfigNETWORK_MTU + ipSIZE_OF_ETH_HEADER ) ) );
      *
      */
-    size_t xAllocSize = 0;
+    size_t xAllocSize = ipconfigNETWORK_MTU + ipSIZE_OF_ETH_HEADER;
 
     for( int x = 0; x < ipconfigNUM_NETWORK_BUFFER_DESCRIPTORS; x++ )
     {
         NetworkBufferDescriptor_t * current = &pxNetworkBuffers[ x ];
-        xAllocSize = ipconfigNETWORK_MTU + ipSIZE_OF_ETH_HEADER;
         current->pucEthernetBuffer = malloc( xAllocSize );
         __CPROVER_assume( current->pucEthernetBuffer != NULL );
         current->xDataLength = sizeof( ARPPacket_t );