Skip to content

Commit 698f2c3

Browse files
committed
Code review suggestion
1 parent 5e842c6 commit 698f2c3

File tree

2 files changed

+22
-50
lines changed

2 files changed

+22
-50
lines changed

source/FreeRTOS_IP.c

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1777,9 +1777,9 @@ static void prvProcessEthernetPacket( NetworkBufferDescriptor_t * const pxNetwor
17771777

17781778
case eWaitingResolution:
17791779

1780-
#if ipconfigIS_ENABLED( ipconfigUSE_IPv4 )
1781-
if( ( pxEthernetHeader->usFrameType == ipIPv4_FRAME_TYPE ) || ( pxEthernetHeader->usFrameType == ipARP_FRAME_TYPE ) )
1782-
{
1780+
if( ( pxEthernetHeader->usFrameType == ipIPv4_FRAME_TYPE ) || ( pxEthernetHeader->usFrameType == ipARP_FRAME_TYPE ) )
1781+
{
1782+
#if ipconfigIS_ENABLED( ipconfigUSE_IPv4 )
17831783
if( pxARPWaitingNetworkBuffer == NULL )
17841784
{
17851785
pxARPWaitingNetworkBuffer = pxNetworkBuffer;
@@ -1788,20 +1788,20 @@ static void prvProcessEthernetPacket( NetworkBufferDescriptor_t * const pxNetwor
17881788
iptraceDELAYED_ARP_REQUEST_STARTED();
17891789
}
17901790
else
1791-
{
1792-
/* We are already waiting on one resolution. This frame will be dropped. */
1793-
vReleaseNetworkBufferAndDescriptor( pxNetworkBuffer );
1794-
1795-
iptraceDELAYED_ARP_BUFFER_FULL();
1796-
}
1791+
#endif /* if ipconfigIS_ENABLED( ipconfigUSE_IPv4 ) */
1792+
{
1793+
/* We are already waiting on one resolution. This frame will be dropped. */
1794+
vReleaseNetworkBufferAndDescriptor( pxNetworkBuffer );
17971795

1798-
break;
1796+
iptraceDELAYED_ARP_BUFFER_FULL();
17991797
}
1800-
#endif /* if ipconfigIS_ENABLED( ipconfigUSE_IPv4 ) */
18011798

1802-
#if ipconfigIS_ENABLED( ipconfigUSE_IPv6 )
1803-
if( pxEthernetHeader->usFrameType == ipIPv6_FRAME_TYPE )
1804-
{
1799+
break;
1800+
}
1801+
1802+
if( pxEthernetHeader->usFrameType == ipIPv6_FRAME_TYPE )
1803+
{
1804+
#if ipconfigIS_ENABLED( ipconfigUSE_IPv6 )
18051805
if( pxNDWaitingNetworkBuffer == NULL )
18061806
{
18071807
pxNDWaitingNetworkBuffer = pxNetworkBuffer;
@@ -1810,16 +1810,16 @@ static void prvProcessEthernetPacket( NetworkBufferDescriptor_t * const pxNetwor
18101810
iptraceDELAYED_ND_REQUEST_STARTED();
18111811
}
18121812
else
1813-
{
1814-
/* We are already waiting on one resolution. This frame will be dropped. */
1815-
vReleaseNetworkBufferAndDescriptor( pxNetworkBuffer );
1816-
1817-
iptraceDELAYED_ND_BUFFER_FULL();
1818-
}
1813+
#endif /* if ipconfigIS_ENABLED( ipconfigUSE_IPv6 ) */
1814+
{
1815+
/* We are already waiting on one resolution. This frame will be dropped. */
1816+
vReleaseNetworkBufferAndDescriptor( pxNetworkBuffer );
18191817

1820-
break;
1818+
iptraceDELAYED_ND_BUFFER_FULL();
18211819
}
1822-
#endif /* if ipconfigIS_ENABLED( ipconfigUSE_IPv6 ) */
1820+
1821+
break;
1822+
}
18231823

18241824
break;
18251825

test.sh

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)