Addresses random issues

Removes an unused variable
Renames  ipBROADCAST_IP_ADDRESS to FREERTOS_INADDR_BROADCAST in the unit tests and the STM32 network driver

Author: Emil Popov

source/FreeRTOS_IPv4.c

@@ -224,7 +224,6 @@ BaseType_t xIsIPv4Broadcast( uint32_t ulIPAddress,
                              struct xNetworkEndPoint ** ppxEndPoint )
 {
     BaseType_t xIsBroadcast;
-    uint32_t ulEndPointBroadcast;
     NetworkEndPoint_t * pxEndPoint;
 
     /* Assign a default answer based on the "global" broadcast.	 This way

source/portable/NetworkInterface/STM32/NetworkInterface.c

@@ -1178,8 +1178,8 @@ static void prvInitMacAddresses( ETH_HandleTypeDef * pxEthHandle,
                         xL3FilterConfig.DestAddrFilterMatch = ETH_L3_DEST_ADDR_PERFECT_MATCH_ENABLE;
                         xL3FilterConfig.SrcAddrHigherBitsMatch = 0x1FU;
                         xL3FilterConfig.DestAddrHigherBitsMatch = 0x1FU;
-                        xL3FilterConfig.Ip4SrcAddr = ipBROADCAST_IP_ADDRESS;
-                        xL3FilterConfig.Ip4DestAddr = ipBROADCAST_IP_ADDRESS;
+                        xL3FilterConfig.Ip4SrcAddr = FREERTOS_INADDR_BROADCAST ;
+                        xL3FilterConfig.Ip4DestAddr = FREERTOS_INADDR_BROADCAST;
                         ( void ) HAL_ETHEx_SetL3FilterConfig( pxEthHandle, ETH_L3_FILTER_0, &xL3FilterConfig );
                     #endif /* if ipconfigIS_DISABLED( ipconfigUSE_IPv4 ) */
 

test/unit-test/FreeRTOS_ARP/FreeRTOS_ARP_utest.c

@@ -2154,7 +2154,7 @@ void test_eARPGetCacheEntry_IPMatchesOtherBroadcastAddr( void )
     struct xNetworkEndPoint * pxEndPoint, xEndPoint;
 
     /* =================================================== */
-    ulIPAddress = FreeRTOS_ntohl( ipBROADCAST_IP_ADDRESS );
+    ulIPAddress = FreeRTOS_ntohl( FREERTOS_INADDR_BROADCAST );
     /* Not worried about what these functions do. */
     FreeRTOS_FindEndPointOnIP_IPv4_ExpectAnyArgsAndReturn( NULL );
     xIsIPv4Loopback_ExpectAndReturn( ulIPAddress, 0UL );

test/unit-test/FreeRTOS_DHCP/FreeRTOS_DHCP_utest.c

@@ -4695,7 +4695,7 @@ void test_vDHCPProcess_eWaitingAcknowledge_IncorrectDNSServerAddress2( void )
     prvWriteDHCPOptionU32( &DHCPOption, dhcpIPv4_SUBNET_MASK_OPTION_CODE, ulSubnetMask );
     prvWriteDHCPOptionU32( &DHCPOption, dhcpIPv4_GATEWAY_OPTION_CODE, ulGateway );
     prvWriteDHCPOptionU32( &DHCPOption, dhcpIPv4_LEASE_TIME_OPTION_CODE, ulLeaseTime );
-    prvWriteDHCPOptionU32( &DHCPOption, dhcpIPv4_DNS_SERVER_OPTIONS_CODE, ipBROADCAST_IP_ADDRESS );
+    prvWriteDHCPOptionU32( &DHCPOption, dhcpIPv4_DNS_SERVER_OPTIONS_CODE, FREERTOS_INADDR_BROADCAST );
 
     *DHCPOption++ = 0xFF;
     TEST_ASSERT_EQUAL( DHCPOption - DHCPMsg, xTotalLength );

test/unit-test/FreeRTOS_DNS/FreeRTOS_DNS_utest.c

@@ -1033,7 +1033,7 @@ void test_FreeRTOS_getaddrinfo_a_IPv4Random_BindFailWithDot( void )
 
     xEndPoint[ 2 ].bits.bIPv6 = pdFALSE;
     xEndPoint[ 2 ].ipv4_settings.ucDNSIndex = 0;
-    xEndPoint[ 2 ].ipv4_settings.ulDNSServerAddresses[ 0 ] = ipBROADCAST_IP_ADDRESS;
+    xEndPoint[ 2 ].ipv4_settings.ulDNSServerAddresses[ 0 ] = FREERTOS_INADDR_BROADCAST;
 
     xEndPoint[ 3 ].bits.bIPv6 = pdFALSE;
     xEndPoint[ 3 ].ipv4_settings.ucDNSIndex = 0;