Fix missing parameters error in ATSAM4E (#1192)

kar-rahul-aws · web-flow · commit 875bfd2d88ba · 2024-09-26T09:21:16.000+05:30
* Fix Missing parameters error in ATSAM4E
diff --git a/source/portable/NetworkInterface/ATSAM4E/NetworkInterface.c b/source/portable/NetworkInterface/ATSAM4E/NetworkInterface.c
@@ -88,7 +88,8 @@
 static BaseType_t xGMACWaitLS( TickType_t xMaxTime );
 
 #if ( ipconfigDRIVER_INCLUDED_TX_IP_CHECKSUM == 1 ) && ( ipconfigHAS_TX_CRC_OFFLOADING == 0 )
-    void vGMACGenerateChecksum( uint8_t * apBuffer );
+    void vGMACGenerateChecksum( uint8_t * pucBuffer,
+                                size_t uxLength );
 #endif
 
 /*
@@ -405,9 +406,10 @@ static BaseType_t xGMACWaitLS( TickType_t xMaxTime )
 
 /*#if( ipconfigDRIVER_INCLUDED_TX_IP_CHECKSUM == 1 ) && ( ipconfigHAS_TX_CRC_OFFLOADING == 0 ) */
 
-void vGMACGenerateChecksum( uint8_t * apBuffer )
+void vGMACGenerateChecksum( uint8_t * pucBuffer,
+                            size_t uxLength )
 {
-    ProtocolPacket_t * xProtPacket = ( ProtocolPacket_t * ) apBuffer;
+    ProtocolPacket_t * xProtPacket = ( ProtocolPacket_t * ) pucBuffer;
 
     if( xProtPacket->xTCPPacket.xEthernetHeader.usFrameType == ipIPv4_FRAME_TYPE )
     {
@@ -419,7 +421,7 @@ void vGMACGenerateChecksum( uint8_t * apBuffer )
         pxIPHeader->usHeaderChecksum = ~FreeRTOS_htons( pxIPHeader->usHeaderChecksum );
 
         /* Calculate the TCP checksum for an outgoing packet. */
-        usGenerateProtocolChecksum( ( uint8_t * ) apBuffer, pdTRUE );
+        usGenerateProtocolChecksum( ( uint8_t * ) pucBuffer, uxLength, pdTRUE );
     }
 }
 
diff --git a/source/portable/NetworkInterface/ATSAM4E/gmac.c b/source/portable/NetworkInterface/ATSAM4E/gmac.c
@@ -642,7 +642,8 @@ uint32_t gmac_dev_read( gmac_device_t * p_gmac_dev,
 }
 
 
-extern void vGMACGenerateChecksum( uint8_t * apBuffer );
+extern void vGMACGenerateChecksum( uint8_t * pucBuffer,
+                                   size_t uxLength );
 
 /**
  * \brief Send ulLength bytes from pcFrom. This copies the buffer to one of the
@@ -715,7 +716,7 @@ uint32_t gmac_dev_write( gmac_device_t * p_gmac_dev,
             memcpy( ( void * ) p_tx_td->addr, p_buffer, ul_size );
         }
         #endif /* ipconfigZERO_COPY_TX_DRIVER */
-        vGMACGenerateChecksum( ( uint8_t * ) p_tx_td->addr );
+        vGMACGenerateChecksum( ( uint8_t * ) p_tx_td->addr, ( size_t ) ul_size );
     }
 
     #if ( GMAC_USES_TX_CALLBACK != 0 )
diff --git a/source/portable/NetworkInterface/DriverSAM/NetworkInterface.c b/source/portable/NetworkInterface/DriverSAM/NetworkInterface.c
@@ -161,7 +161,7 @@ static BaseType_t xPHY_Write( BaseType_t xAddress,
                               uint32_t ulValue );
 
 #if ( ipconfigDRIVER_INCLUDED_TX_IP_CHECKSUM == 1 ) && ( ipconfigHAS_TX_CRC_OFFLOADING == 0 )
-    void vGMACGenerateChecksum( uint8_t * apBuffer,
+    void vGMACGenerateChecksum( uint8_t * pucBuffer,
                                 size_t uxLength );
 #endif
 
diff --git a/source/portable/NetworkInterface/DriverSAM/gmac_SAM.h b/source/portable/NetworkInterface/DriverSAM/gmac_SAM.h
@@ -1539,7 +1539,7 @@
 
 /* The SAM4E has problems offloading checksums for transmission.
  * The SAME70 does not set the CRC for ICMP packets (ping). */
-    extern void vGMACGenerateChecksum( uint8_t * apBuffer,
+    extern void vGMACGenerateChecksum( uint8_t * pucBuffer,
                                        size_t uxLength );
 
 /*/ @cond 0 */

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,8 @@`
`88`	`88`	`static BaseType_t xGMACWaitLS( TickType_t xMaxTime );`
`89`	`89`
`90`	`90`	`#if ( ipconfigDRIVER_INCLUDED_TX_IP_CHECKSUM == 1 ) && ( ipconfigHAS_TX_CRC_OFFLOADING == 0 )`
`91`		`- void vGMACGenerateChecksum( uint8_t * apBuffer );`
	`91`	`+ void vGMACGenerateChecksum( uint8_t * pucBuffer,`
	`92`	`+ size_t uxLength );`
`92`	`93`	`#endif`
`93`	`94`
`94`	`95`	`/*`
`@@ -405,9 +406,10 @@ static BaseType_t xGMACWaitLS( TickType_t xMaxTime )`
`405`	`406`
`406`	`407`	`/#if( ipconfigDRIVER_INCLUDED_TX_IP_CHECKSUM == 1 ) && ( ipconfigHAS_TX_CRC_OFFLOADING == 0 ) /`
`407`	`408`
`408`		`-void vGMACGenerateChecksum( uint8_t * apBuffer )`
	`409`	`+void vGMACGenerateChecksum( uint8_t * pucBuffer,`
	`410`	`+ size_t uxLength )`
`409`	`411`	`{`
`410`		`- ProtocolPacket_t * xProtPacket = ( ProtocolPacket_t * ) apBuffer;`
	`412`	`+ ProtocolPacket_t * xProtPacket = ( ProtocolPacket_t * ) pucBuffer;`
`411`	`413`
`412`	`414`	`if( xProtPacket->xTCPPacket.xEthernetHeader.usFrameType == ipIPv4_FRAME_TYPE )`
`413`	`415`	`{`
`@@ -419,7 +421,7 @@ void vGMACGenerateChecksum( uint8_t * apBuffer )`
`419`	`421`	`pxIPHeader->usHeaderChecksum = ~FreeRTOS_htons( pxIPHeader->usHeaderChecksum );`
`420`	`422`
`421`	`423`	`/* Calculate the TCP checksum for an outgoing packet. */`
`422`		`- usGenerateProtocolChecksum( ( uint8_t * ) apBuffer, pdTRUE );`
	`424`	`+ usGenerateProtocolChecksum( ( uint8_t * ) pucBuffer, uxLength, pdTRUE );`
`423`	`425`	`}`
`424`	`426`	`}`
`425`	`427`
Original file line number	Diff line number	Diff line change
`@@ -642,7 +642,8 @@ uint32_t gmac_dev_read( gmac_device_t * p_gmac_dev,`
`642`	`642`	`}`
`643`	`643`
`644`	`644`
`645`		`-extern void vGMACGenerateChecksum( uint8_t * apBuffer );`
	`645`	`+extern void vGMACGenerateChecksum( uint8_t * pucBuffer,`
	`646`	`+ size_t uxLength );`
`646`	`647`
`647`	`648`	`/**`
`648`	`649`	`* \brief Send ulLength bytes from pcFrom. This copies the buffer to one of the`
`@@ -715,7 +716,7 @@ uint32_t gmac_dev_write( gmac_device_t * p_gmac_dev,`
`715`	`716`	`memcpy( ( void * ) p_tx_td->addr, p_buffer, ul_size );`
`716`	`717`	`}`
`717`	`718`	`#endif /* ipconfigZERO_COPY_TX_DRIVER */`
`718`		`- vGMACGenerateChecksum( ( uint8_t * ) p_tx_td->addr );`
	`719`	`+ vGMACGenerateChecksum( ( uint8_t * ) p_tx_td->addr, ( size_t ) ul_size );`
`719`	`720`	`}`
`720`	`721`
`721`	`722`	`#if ( GMAC_USES_TX_CALLBACK != 0 )`