Addresses random issues

Removes an unused variable
Renames  ipBROADCAST_IP_ADDRESS to FREERTOS_INADDR_BROADCAST in the unit tests.

Author: Emil Popov

source/FreeRTOS_IPv4.c

@@ -224,7 +224,6 @@ BaseType_t xIsIPv4Broadcast( uint32_t ulIPAddress,
                              struct xNetworkEndPoint ** ppxEndPoint )
 {
     BaseType_t xIsBroadcast;
-    uint32_t ulEndPointBroadcast;
     NetworkEndPoint_t * pxEndPoint;
 
     /* Assign a default answer based on the "global" broadcast.	 This way

test/unit-test/FreeRTOS_ARP/FreeRTOS_ARP_utest.c

@@ -2154,7 +2154,7 @@ void test_eARPGetCacheEntry_IPMatchesOtherBroadcastAddr( void )
     struct xNetworkEndPoint * pxEndPoint, xEndPoint;
 
     /* =================================================== */
-    ulIPAddress = FreeRTOS_ntohl( ipBROADCAST_IP_ADDRESS );
+    ulIPAddress = FreeRTOS_ntohl( FREERTOS_INADDR_BROADCAST );
     /* Not worried about what these functions do. */
     FreeRTOS_FindEndPointOnIP_IPv4_ExpectAnyArgsAndReturn( NULL );
     xIsIPv4Loopback_ExpectAndReturn( ulIPAddress, 0UL );

test/unit-test/FreeRTOS_DHCP/FreeRTOS_DHCP_utest.c

@@ -4695,7 +4695,7 @@ void test_vDHCPProcess_eWaitingAcknowledge_IncorrectDNSServerAddress2( void )
     prvWriteDHCPOptionU32( &DHCPOption, dhcpIPv4_SUBNET_MASK_OPTION_CODE, ulSubnetMask );
     prvWriteDHCPOptionU32( &DHCPOption, dhcpIPv4_GATEWAY_OPTION_CODE, ulGateway );
     prvWriteDHCPOptionU32( &DHCPOption, dhcpIPv4_LEASE_TIME_OPTION_CODE, ulLeaseTime );
-    prvWriteDHCPOptionU32( &DHCPOption, dhcpIPv4_DNS_SERVER_OPTIONS_CODE, ipBROADCAST_IP_ADDRESS );
+    prvWriteDHCPOptionU32( &DHCPOption, dhcpIPv4_DNS_SERVER_OPTIONS_CODE, FREERTOS_INADDR_BROADCAST );
 
     *DHCPOption++ = 0xFF;
     TEST_ASSERT_EQUAL( DHCPOption - DHCPMsg, xTotalLength );