Merge branch 'main' into update_workflow_permission

Author: tony-josi-aws

source/FreeRTOS_DNS_Parser.c

@@ -262,7 +262,7 @@
         uint16_t x;
         BaseType_t xReturn = pdTRUE;
         uint32_t ulIPAddress = 0U;
-        BaseType_t xDNSHookReturn;
+        BaseType_t xDNSHookReturn = 0U;
 
         ( void ) memset( &( xSet ), 0, sizeof( xSet ) );
         xSet.usPortNumber = usPort;

source/FreeRTOS_IPv4.c

@@ -82,7 +82,7 @@
 
         /* Map the buffer onto a IP-Packet struct to easily access the
          * fields of the IP packet. */
-        const IPPacket_t * const pxIPPacket = ( ( const IPPacket_t * const ) pvEthernetBuffer );
+        const IPPacket_t * const pxIPPacket = ( ( const IPPacket_t * ) pvEthernetBuffer );
 
         DEBUG_DECLARE_TRACE_VARIABLE( BaseType_t, xLocation, 0 );
 

source/FreeRTOS_IPv6.c

@@ -99,11 +99,11 @@ const struct xIPv6_Address FreeRTOS_in6addr_loopback = { { 0U, 0U, 0U, 0U, 0U, 0
         size_t uxMinimumLength;
         size_t uxExtHeaderLength = 0;
         const IPExtHeader_IPv6_t * pxExtHeader = NULL;
-        const uint8_t * const pucEthernetBuffer = ( const uint8_t * const ) pvEthernetBuffer;
+        const uint8_t * const pucEthernetBuffer = ( const uint8_t * ) pvEthernetBuffer;
 
         /* Map the buffer onto a IPv6-Packet struct to easily access the
          * fields of the IPv6 packet. */
-        const IPPacket_IPv6_t * const pxIPv6Packet = ( const IPPacket_IPv6_t * const ) pucEthernetBuffer;
+        const IPPacket_IPv6_t * const pxIPv6Packet = ( const IPPacket_IPv6_t * ) pucEthernetBuffer;
 
         DEBUG_DECLARE_TRACE_VARIABLE( BaseType_t, xLocation, 0 );
 

source/FreeRTOS_ND.c

@@ -97,12 +97,6 @@
 /** @brief The ND cache. */
     static NDCacheRow_t xNDCache[ ipconfigND_CACHE_ENTRIES ];
 
-/** @brief  The time at which the last unsolicited ND was sent. Unsolicited NDs are used
- * to ensure ND tables are up to date and to detect IP address conflicts. */
-/* MISRA Ref 8.9.1 [File scoped variables] */
-/* More details at: https://github.com/FreeRTOS/FreeRTOS-Plus-TCP/blob/main/MISRA.md#rule-89 */
-/* coverity[misra_c_2012_rule_8_9_violation] */
-    static TickType_t xLastUnsolicitedNDTime = 0U;
 
 /*-----------------------------------------------------------*/
 
@@ -1405,19 +1399,4 @@
     }
 
 /*-----------------------------------------------------------*/
-
-/**
- * @brief Send an unsolicited ND packet to allow this node to announce the IP-MAC
- *        mapping to the entire network.
- */
-    void vNDSendUnsolicited( void )
-    {
-        /* Setting xLastUnsolicitedNDTime to 0 will force an unsolicited ND the next
-         * time vNDAgeCache() is called. */
-        xLastUnsolicitedNDTime = ( TickType_t ) 0;
-
-        /* Let the IP-task call vARPAgeCache(). */
-        ( void ) xSendEventToIPTask( eNDTimerEvent );
-    }
-/*-----------------------------------------------------------*/
 #endif /* ipconfigUSE_IPv6 */

source/FreeRTOS_RA.c

@@ -329,12 +329,14 @@
 
                 case ndICMP_MTU_OPTION: /* 5 */
                    {
-                       uint32_t ulMTU;
-                       ( void ) ulMTU;
-
-                       /* ulChar2u32 returns host-endian numbers. */
-                       ulMTU = ulChar2u32( &( pucBytes[ uxIndex + 4U ] ) );
-                       FreeRTOS_printf( ( "RA: MTU = %u\n", ( unsigned int ) ulMTU ) );
+                       #if ipconfigHAS_PRINTF == 1
+                           uint32_t ulMTU;
+                           ( void ) ulMTU;
+
+                           /* ulChar2u32 returns host-endian numbers. */
+                           ulMTU = ulChar2u32( &( pucBytes[ uxIndex + 4U ] ) );
+                           FreeRTOS_printf( ( "RA: MTU = %u\n", ( unsigned int ) ulMTU ) );
+                       #endif /* ipconfigHAS_PRINTF == 1 */
                    }
                    break;
 

source/include/FreeRTOS_ND.h

@@ -209,8 +209,6 @@
 /* Clear all entries in the ND cache. */
     void FreeRTOS_ClearND( const struct xNetworkEndPoint * pxEndPoint );
 
-    void vNDSendUnsolicited( void );
-
     extern const uint8_t pcLOCAL_ALL_NODES_MULTICAST_IP[ ipSIZE_OF_IPv6_ADDRESS ];
     extern const uint8_t pcLOCAL_ALL_NODES_MULTICAST_MAC[ ipMAC_ADDRESS_LENGTH_BYTES ];
 

source/portable/BufferManagement/BufferAllocation_1.c

@@ -313,6 +313,7 @@ NetworkBufferDescriptor_t * pxGetNetworkBufferWithDescriptor( size_t xRequestedS
         }
         else
         {
+            FreeRTOS_printf( ( "pxGetNetworkBufferWithDescriptor: module not initialised or `xRequestedSizeBytes` too small" ) );
             /* lint wants to see at least a comment. */
             iptraceFAILED_TO_OBTAIN_NETWORK_BUFFER();
         }

source/portable/NetworkInterface/STM32/Legacy/STM32Hxx/NetworkInterface.c

@@ -392,7 +392,8 @@ static BaseType_t xSTM32H_NetworkInterfaceInitialise( NetworkInterface_t * pxInt
 
                 #if ( ipconfigZERO_COPY_RX_DRIVER != 0 )
                 {
-                    pucBuffer = pucGetRXBuffer( ETH_RX_BUF_SIZE );
+                    /* Subtracted 'ipBUFFER_PADDING', which is the size of the meta data. */
+                    pucBuffer = pucGetRXBuffer( ETH_RX_BUF_SIZE - ipBUFFER_PADDING );
                     configASSERT( pucBuffer != NULL );
                 }
                 #else
@@ -1046,7 +1047,7 @@ size_t uxNetworkInterfaceAllocateRAMToBuffers( NetworkBufferDescriptor_t pxNetwo
         ucRAMBuffer += ETH_RX_BUF_SIZE;
     }
 
-    return (ETH_RX_BUF_SIZE - ipBUFFER_PADDING);
+    return( ETH_RX_BUF_SIZE - ipBUFFER_PADDING );
 }
 /*-----------------------------------------------------------*/
 

test/unit-test/FreeRTOS_ND/FreeRTOS_ND_utest.c

@@ -2139,13 +2139,3 @@ void test_xCheckRequiresNDResolution_AssertInvalidFrameType( void )
 
     catch_assert( xCheckRequiresNDResolution( pxNetworkBuffer ) );
 }
-
-/**
- * @brief Toggle vNDSendUnsolicited.
- */
-void test_vNDSendUnsolicited( void )
-{
-    xSendEventToIPTask_ExpectAndReturn( eNDTimerEvent, 0 );
-
-    vNDSendUnsolicited();
-}