Apply suggestions from code review

Co-authored-by: Błażej Sowa <[email protected]>

Author: HTRamsey

source/portable/NetworkInterface/STM32/CMakeLists.txt

@@ -5,9 +5,35 @@ endif()
 #------------------------------------------------------------------------------
 add_library( freertos_plus_tcp_network_if STATIC )
 
+set( FREERTOS_PLUS_TCP_STM32_IF_DRIVER "None" CACHE STRING "The driver sources to use with STM32 Network interface" )
+
 target_sources( freertos_plus_tcp_network_if
   PRIVATE
     NetworkInterface.c
+    $<$<STREQUAL:${FREERTOS_PLUS_TCP_STM32_IF_DRIVER},F4>:
+      Drivers/F4/stm32f4xx_hal_eth.c>
+    $<$<STREQUAL:${FREERTOS_PLUS_TCP_STM32_IF_DRIVER},F7>:
+      Drivers/F7/stm32f7xx_hal_eth.c>
+    $<$<STREQUAL:${FREERTOS_PLUS_TCP_STM32_IF_DRIVER},H5>:
+      Drivers/H5/stm32h5xx_hal_eth_ex.c>
+    $<$<STREQUAL:${FREERTOS_PLUS_TCP_STM32_IF_DRIVER},H5>:
+      Drivers/H5/stm32h5xx_hal_eth.c>
+    $<$<STREQUAL:${FREERTOS_PLUS_TCP_STM32_IF_DRIVER},H7>:
+      Drivers/H7/stm32h7xx_hal_eth_ex.c>
+    $<$<STREQUAL:${FREERTOS_PLUS_TCP_STM32_IF_DRIVER},H7>:
+      Drivers/H7/stm32h7xx_hal_eth.c>
+)
+
+target_include_directories( freertos_plus_tcp_network_if 
+  PUBLIC
+    $<$<STREQUAL:${FREERTOS_PLUS_TCP_STM32_IF_DRIVER},F4>:
+      Drivers/F4>
+    $<$<STREQUAL:${FREERTOS_PLUS_TCP_STM32_IF_DRIVER},F7>:
+      Drivers/F7>
+    $<$<STREQUAL:${FREERTOS_PLUS_TCP_STM32_IF_DRIVER},H5>:
+      Drivers/H5>
+    $<$<STREQUAL:${FREERTOS_PLUS_TCP_STM32_IF_DRIVER},H7>:
+      Drivers/H7>
 )
 
 target_link_libraries( freertos_plus_tcp_network_if

source/portable/NetworkInterface/STM32/NetworkInterface.c

@@ -1194,7 +1194,7 @@ static void prvInitMacAddresses( ETH_HandleTypeDef * pxEthHandle,
     #endif
 
     #if ipconfigIS_ENABLED( ipconfigUSE_IPv6 )
-        prvAddAllowedMACAddress( pxInterface, pcLOCAL_ALL_NODES_MULTICAST_MAC.ucBytes );
+        prvAddAllowedMACAddress( pxInterface, pcLOCAL_ALL_NODES_MULTICAST_MAC );
         #if ipconfigIS_ENABLED( ipconfigUSE_MDNS )
             prvAddAllowedMACAddress( pxInterface, xMDNS_MacAddressIPv6.ucBytes );
         #endif