Fix formatting

Author: tony-josi-aws

test/cbmc/proofs/parsing/ProcessIPPacket/ProcessIPPacket_harness.c

@@ -158,7 +158,7 @@ void harness()
     uint8_t * pucEthernetBuffer = ( uint8_t * ) safeMalloc( ipTOTAL_ETHERNET_FRAME_SIZE + ipIP_TYPE_OFFSET );
     EthernetHeader_t * pxHeader;
     NetworkEndPoint_t xEndPoint;
-    
+
     __CPROVER_assume( pxNetworkBuffer != NULL );
     __CPROVER_assume( pucEthernetBuffer != NULL );
 
@@ -168,15 +168,15 @@ void harness()
     __CPROVER_assume( pxNetworkBuffer->pucEthernetBuffer != NULL );
 
     /* prvProcessIPPacket is guranteed to receive a network buffer that has a valid
-    endpoint, hence no NULL checks are needed to be performed inside prvProcessIPPacket.
-    See the check:
-        
-        if( ( pxNetworkBuffer->pxInterface == NULL ) || ( pxNetworkBuffer->pxEndPoint == NULL ) )
-        {
-            break;
-        }
-
-    inside the prvProcessEthernetPacket before which prvProcessIPPacket is called.
+     * endpoint, hence no NULL checks are needed to be performed inside prvProcessIPPacket.
+     * See the check:
+     *
+     *  if( ( pxNetworkBuffer->pxInterface == NULL ) || ( pxNetworkBuffer->pxEndPoint == NULL ) )
+     *  {
+     *      break;
+     *  }
+     *
+     * inside the prvProcessEthernetPacket before which prvProcessIPPacket is called.
      */
     pxNetworkBuffer->pxEndPoint = &xEndPoint;
 

test/unit-test/FreeRTOS_ARP/FreeRTOS_ARP_utest.c

@@ -2077,7 +2077,7 @@ void test_eARPGetCacheEntry_IPMatchesBroadcastAddr( void )
     xIsIPv4Loopback_ExpectAndReturn( ulIPAddress, 0UL );
     xIsIPv4Multicast_ExpectAndReturn( ulIPAddress, 0UL );
     xIsIPv4Broadcast_ExpectAnyArgsAndReturn( 1UL );
-    xIsIPv4Broadcast_ReturnThruPtr_ppxEndPoint(&pxEndPoint2);
+    xIsIPv4Broadcast_ReturnThruPtr_ppxEndPoint( &pxEndPoint2 );
 
     eResult = eARPGetCacheEntry( &ulIPAddress, &xMACAddress, &pxEndPoint );
 
@@ -2102,7 +2102,7 @@ void test_eARPGetCacheEntry_IPMatchesBroadcastAddr_NullEndPointOnNetMask( void )
     xIsIPv4Loopback_ExpectAndReturn( ulIPAddress, 0UL );
     xIsIPv4Multicast_ExpectAndReturn( ulIPAddress, 0UL );
     xIsIPv4Broadcast_ExpectAnyArgsAndReturn( 1UL );
-    xIsIPv4Broadcast_ReturnThruPtr_ppxEndPoint(&pxEndPoint2);
+    xIsIPv4Broadcast_ReturnThruPtr_ppxEndPoint( &pxEndPoint2 );
 
     eResult = eARPGetCacheEntry( &ulIPAddress, &xMACAddress, &pxEndPoint );
 
@@ -2155,14 +2155,14 @@ void test_eARPGetCacheEntry_IPMatchesOtherBroadcastAddr( void )
     struct xNetworkInterface * xInterface;
     struct xNetworkEndPoint * pxEndPoint, xEndPoint;
     struct xNetworkEndPoint * pxEndPoint2 = &xEndPoint;
-    
+
     /* =================================================== */
     ulIPAddress = FreeRTOS_ntohl( FREERTOS_INADDR_BROADCAST );
     /* Not worried about what these functions do. */
     xIsIPv4Loopback_ExpectAndReturn( ulIPAddress, 0UL );
     xIsIPv4Multicast_ExpectAndReturn( ulIPAddress, 0UL );
     xIsIPv4Broadcast_ExpectAnyArgsAndReturn( 1UL );
-    xIsIPv4Broadcast_ReturnThruPtr_ppxEndPoint(&pxEndPoint2);
+    xIsIPv4Broadcast_ReturnThruPtr_ppxEndPoint( &pxEndPoint2 );
     eResult = eARPGetCacheEntry( &ulIPAddress, &xMACAddress, &pxEndPoint );
     TEST_ASSERT_EQUAL_MESSAGE( eResolutionCacheHit, eResult, "Test 3" );
     TEST_ASSERT_EQUAL_MEMORY_MESSAGE( &xBroadcastMACAddress, &xMACAddress, sizeof( xMACAddress ), "Test 3" );

test/unit-test/FreeRTOS_IPv4/FreeRTOS_IPv4_utest.c

@@ -131,7 +131,7 @@ void test_xIsIPv4Broadcast_BroadcastAddress( void )
 {
     BaseType_t xIsBroadcast;
     NetworkEndPoint_t xEndPoints[ 2 ]; /* IPv6->IPv4 */
-    NetworkEndPoint_t *pxEndPoint = NULL;
+    NetworkEndPoint_t * pxEndPoint = NULL;
 
     memset( &xEndPoints[ 0 ], 0, sizeof( NetworkEndPoint_t ) );
     xEndPoints[ 0 ].bits.bIPv6 = pdTRUE;
@@ -142,15 +142,15 @@ void test_xIsIPv4Broadcast_BroadcastAddress( void )
     FreeRTOS_FirstEndPoint_ExpectAnyArgsAndReturn( &xEndPoints[ 0 ] );
     FreeRTOS_NextEndPoint_ExpectAndReturn( NULL, &xEndPoints[ 0 ], &xEndPoints[ 1 ] );
 
-    xIsBroadcast = xIsIPv4Broadcast(FREERTOS_INADDR_BROADCAST, &pxEndPoint);
+    xIsBroadcast = xIsIPv4Broadcast( FREERTOS_INADDR_BROADCAST, &pxEndPoint );
 
     TEST_ASSERT_EQUAL( pdTRUE, xIsBroadcast );
     TEST_ASSERT_EQUAL( &xEndPoints[ 1 ], pxEndPoint );
 }
 
 /**
  * @brief test_xIsIPv4Broadcast_BroadcastAddressNoPtr
- * To validate if xIsIPv4Broadcast() when given broadcast address but 
+ * To validate if xIsIPv4Broadcast() when given broadcast address but
  * no input EP pointer.
  */
 void test_xIsIPv4Broadcast_BroadcastAddressNoPtr( void )
@@ -167,22 +167,22 @@ void test_xIsIPv4Broadcast_BroadcastAddressNoPtr( void )
     FreeRTOS_FirstEndPoint_ExpectAnyArgsAndReturn( &xEndPoints[ 0 ] );
     FreeRTOS_NextEndPoint_ExpectAndReturn( NULL, &xEndPoints[ 0 ], &xEndPoints[ 1 ] );
 
-    xIsBroadcast = xIsIPv4Broadcast(FREERTOS_INADDR_BROADCAST, NULL);
+    xIsBroadcast = xIsIPv4Broadcast( FREERTOS_INADDR_BROADCAST, NULL );
 
     TEST_ASSERT_EQUAL( pdTRUE, xIsBroadcast );
 }
 
 /**
  * @brief test_xIsIPv4Broadcast_BroadcastAddressNotFREERTOS_INADDR_BROADCAST
- * To validate if 
- * test_xIsIPv4Broadcast_BroadcastAddressNotFREERTOS_INADDR_BROADCAST() 
+ * To validate if
+ * test_xIsIPv4Broadcast_BroadcastAddressNotFREERTOS_INADDR_BROADCAST()
  * when given broadcast address but not FREERTOS_INADDR_BROADCAST.
  */
 void test_xIsIPv4Broadcast_BroadcastAddressNotFREERTOS_INADDR_BROADCAST( void )
 {
     BaseType_t xIsBroadcast;
     NetworkEndPoint_t xEndPoints[ 2 ]; /* IPv6->IPv4 */
-    NetworkEndPoint_t *pxEndPoint = NULL;
+    NetworkEndPoint_t * pxEndPoint = NULL;
 
     memset( &xEndPoints[ 0 ], 0, sizeof( NetworkEndPoint_t ) );
     xEndPoints[ 0 ].bits.bIPv6 = pdTRUE;
@@ -193,7 +193,7 @@ void test_xIsIPv4Broadcast_BroadcastAddressNotFREERTOS_INADDR_BROADCAST( void )
     FreeRTOS_FirstEndPoint_ExpectAnyArgsAndReturn( &xEndPoints[ 0 ] );
     FreeRTOS_NextEndPoint_ExpectAndReturn( NULL, &xEndPoints[ 0 ], &xEndPoints[ 1 ] );
 
-    xIsBroadcast = xIsIPv4Broadcast(0xFFFF1234, &pxEndPoint);
+    xIsBroadcast = xIsIPv4Broadcast( 0xFFFF1234, &pxEndPoint );
 
     TEST_ASSERT_EQUAL( pdTRUE, xIsBroadcast );
     TEST_ASSERT_EQUAL( &xEndPoints[ 1 ], pxEndPoint );
@@ -207,7 +207,7 @@ void test_xIsIPv4Broadcast_NotBroadcastAddress( void )
 {
     BaseType_t xIsBroadcast;
     NetworkEndPoint_t xEndPoints[ 2 ]; /* IPv6->IPv4 */
-    NetworkEndPoint_t *pxEndPoint = NULL;
+    NetworkEndPoint_t * pxEndPoint = NULL;
 
     memset( &xEndPoints[ 0 ], 0, sizeof( NetworkEndPoint_t ) );
     xEndPoints[ 0 ].bits.bIPv6 = pdTRUE;
@@ -219,7 +219,7 @@ void test_xIsIPv4Broadcast_NotBroadcastAddress( void )
     FreeRTOS_NextEndPoint_ExpectAndReturn( NULL, &xEndPoints[ 0 ], &xEndPoints[ 1 ] );
     FreeRTOS_NextEndPoint_ExpectAndReturn( NULL, &xEndPoints[ 1 ], NULL );
 
-    xIsBroadcast = xIsIPv4Broadcast(0xABCD1235, &pxEndPoint);
+    xIsBroadcast = xIsIPv4Broadcast( 0xABCD1235, &pxEndPoint );
 
     TEST_ASSERT_EQUAL( pdFALSE, xIsBroadcast );
     TEST_ASSERT_EQUAL( NULL, pxEndPoint );
@@ -232,28 +232,28 @@ void test_xIsIPv4Broadcast_NotBroadcastAddress( void )
 void test_xIsIPv4Broadcast_NoEndPoints( void )
 {
     BaseType_t xIsBroadcast;
-    NetworkEndPoint_t *pxEndPoint = NULL;
+    NetworkEndPoint_t * pxEndPoint = NULL;
 
     FreeRTOS_FirstEndPoint_ExpectAnyArgsAndReturn( NULL );
 
-    xIsBroadcast = xIsIPv4Broadcast(0xABCD1235, &pxEndPoint);
+    xIsBroadcast = xIsIPv4Broadcast( 0xABCD1235, &pxEndPoint );
 
     TEST_ASSERT_EQUAL( pdFALSE, xIsBroadcast );
     TEST_ASSERT_EQUAL( NULL, pxEndPoint );
 }
 
 /**
  * @brief test_xIsIPv4Broadcast_NoEndPointsNoPtr
- * To validate if xIsIPv4Broadcast() when no endpoints are there 
+ * To validate if xIsIPv4Broadcast() when no endpoints are there
  * and no pointer given.
  */
 void test_xIsIPv4Broadcast_NoEndPointsNoPtr( void )
 {
     BaseType_t xIsBroadcast;
-    
+
     FreeRTOS_FirstEndPoint_ExpectAnyArgsAndReturn( NULL );
 
-    xIsBroadcast = xIsIPv4Broadcast(0xABCD1235, NULL);
+    xIsBroadcast = xIsIPv4Broadcast( 0xABCD1235, NULL );
 
     TEST_ASSERT_EQUAL( pdFALSE, xIsBroadcast );
 }