[BUG] ATSAME5x network interface not detecting ICMP packets correctly

[cruxic]

The example network interface for ATSAME5x does not correctly detect ICMP packets. The codes checks the protocol byte but fails to also check the Ethernet frame type. This causes it to get false-positive matches for frames which happen to have an 0x01 byte at a certain offset.

The same bug exists in two places in the code: xATSAM5x_NetworkInterfaceOutput() and prvEMACDeferredInterruptHandlerTask(). I will be submitting a pull-request which fixes it.

[jasonpcarroll]

Hi @cruxic,
Thank you for bringing this to our attention. I will review your PR.

[htibosch]

Good catch, thank you!

In the driver for Zynq, the ICMP packets are detected correctly, both for IPv4 and for IPv6.

The MSP432 driver has same problem and needs correction too.

[aggarg]

Thank you for your contribution!