Unittest: Fix, enable and forbid specific warnings #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the effort, we'll have the team to review the change. |
ActoryOu
reviewed
Feb 26, 2025
Member
ActoryOu
left a comment
ActoryOu
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
I'm good with most of changes. And here are some nitpicky suggestions from me.
This commit also fixes 4 of these warnings, that occured once each,
namely -Werror={switch,memset-elt-size,comment,unused-value}.
anordal
force-pushed
the
unittest-warnings
branch
from
d3128e8 to
2926188
Compare
tony-josi-aws
approved these changes
Mar 10, 2025
kar-rahul-aws
approved these changes
Mar 12, 2025
ActoryOu
approved these changes
Mar 12, 2025
Member
|
Thanks, @anordal, for your contribution to FreeRTOS+TCP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's build unittests with certain warnings enabled and turned into errors.
This will make them fail in CI and also make them look like errors in editors that use a language server.
In particular,
-Werror=uninitialized(make compilation fail when all control paths use a variable uninitialized).The first commit is devoted to fixing these.
Motivation: Most of the crashing tests I fixed in #1151 were caused by reading uninitialized memory. As I suggested there, the kinds of errors I had to fix could have been prevented by enabling certain warnings as errors.
Checklist:
Related Issue
This is a continuation of #1151.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.