Fix Zynq network interface incoming packet filtering by correcting endianness #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarg
previously approved these changes
Feb 27, 2025
Contributor
|
Hi @tony-josi-aws and @aggarg, I believe this change also applies to the xilinx_ultrascale port, I am really busy at the moment and don't have time to do a PR would you be able to expand this PR to include the change also for that port? here is a link to the port... Kind Regards, Pete |
ActoryOu
previously approved these changes
Feb 27, 2025
Member
Author
|
Updated xilinx_ultrascale port. |
aggarg
approved these changes
Feb 28, 2025
kar-rahul-aws
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Zynq network interface packet filtering, if enabled, could drop packets with fragment flags (don't fragment and may fragment bits) set incorrectly as
ipFRAGMENT_OFFSET_BIT_MASKflag is already defined to be matching as per the endian requirement based on theipconfigBYTE_ORDER, and doesn’t needFreeRTOS_ntohsagain.This PR fixes the issue.
User reported issue of pings not replied from Zynq when requested from specific hosts.
Test Steps
Author of the issue confirmed the fix
Checklist:
[ ] I have tested my changes. No regression in existing tests.[ ] I have modified and/or added unit-tests to cover the code changes in this Pull Request.Related Issue
https://forums.freertos.org/t/ping-not-working-trouble-getting-started-w-freertos-tcp-on-zynq-zedboard/22117
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.