[BUG] Version 4.3.2 breaks the DriverSAM network driver

[evpopov]

Describe the bug
This check
was added to BufferAllocation_1 in this most recent version 4.3.2. The check results in all buffer requests with a size of more than 1514 to fail.

The SAME70 Ethernet driver that I'm using and possibly other drivers request much larger buffers during initialization.
DriverSAM example where the size is 1536 + some padding
Note: I consider "1536 + some padding" to be the correct size for the buffers, because in many cases ( including my own ) the maximum Ethernet packet is larger than 1514 due to things like the possible inclusion of the FCS field and maybe multiple VLAN tags.

The result of the new check is that the driver initialization fails.
I know how to fix this for myself, but I'm creating this issue to raise awareness. The task of allocating network buffers is delegated to the network driver as stated in this comment and I don't think it's right for pxGetNetworkBufferWithDescriptor() to impose it's own random restriction when .

Target

• SAME70 and probably others

[ActoryOu]

Hi @evpopov,
Thank you for bringing this into our attention!
Would you mind creating a PR for this?

At the meanwhile, we'll try to find the solution from our end.

Thank you.

[tony-josi-aws]

@evpopov

We have created a patch PR here: #1263
Can you try if the fix works for you?

[evpopov]

Thanks @tony-josi-aws
Sorry for not proposing a solution or PR, but I was in a hurry to bring this to your attention and didn't have a good clean idea for a proper fix.
I like the patch a lot. I don't see any issues with it and in my limited testing it seems to be addressing the issue.