From 8887ebe4213544ff6c2d2fa7904cd34486d397a6 Mon Sep 17 00:00:00 2001 From: Hein Tibosch Date: Wed, 6 Aug 2025 23:52:49 +0800 Subject: [PATCH 1/2] STM32H legacy driver: change parameter to pucGetRXBuffer() --- .../NetworkInterface/STM32/Legacy/STM32Hxx/NetworkInterface.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source/portable/NetworkInterface/STM32/Legacy/STM32Hxx/NetworkInterface.c b/source/portable/NetworkInterface/STM32/Legacy/STM32Hxx/NetworkInterface.c index 76c6eac448..6429c12293 100644 --- a/source/portable/NetworkInterface/STM32/Legacy/STM32Hxx/NetworkInterface.c +++ b/source/portable/NetworkInterface/STM32/Legacy/STM32Hxx/NetworkInterface.c @@ -392,7 +392,8 @@ static BaseType_t xSTM32H_NetworkInterfaceInitialise( NetworkInterface_t * pxInt #if ( ipconfigZERO_COPY_RX_DRIVER != 0 ) { - pucBuffer = pucGetRXBuffer( ETH_RX_BUF_SIZE ); + /* Subtracted 'ipBUFFER_PADDING', which is the size of the meta data. */ + pucBuffer = pucGetRXBuffer( ETH_RX_BUF_SIZE - ipBUFFER_PADDING ); configASSERT( pucBuffer != NULL ); } #else From b2821b63656ec463bd701d4d3a7b5e9454d77c10 Mon Sep 17 00:00:00 2001 From: Hein Tibosch Date: Thu, 7 Aug 2025 00:08:08 +0800 Subject: [PATCH 2/2] The actual changes --- source/portable/BufferManagement/BufferAllocation_1.c | 1 + .../STM32/Legacy/STM32Hxx/NetworkInterface.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/source/portable/BufferManagement/BufferAllocation_1.c b/source/portable/BufferManagement/BufferAllocation_1.c index 566d94867c..0dc8eaeb27 100644 --- a/source/portable/BufferManagement/BufferAllocation_1.c +++ b/source/portable/BufferManagement/BufferAllocation_1.c @@ -313,6 +313,7 @@ NetworkBufferDescriptor_t * pxGetNetworkBufferWithDescriptor( size_t xRequestedS } else { + FreeRTOS_printf( ( "pxGetNetworkBufferWithDescriptor: module not initialised or `xRequestedSizeBytes` too small" ) ); /* lint wants to see at least a comment. */ iptraceFAILED_TO_OBTAIN_NETWORK_BUFFER(); } diff --git a/source/portable/NetworkInterface/STM32/Legacy/STM32Hxx/NetworkInterface.c b/source/portable/NetworkInterface/STM32/Legacy/STM32Hxx/NetworkInterface.c index 6429c12293..f78224a609 100644 --- a/source/portable/NetworkInterface/STM32/Legacy/STM32Hxx/NetworkInterface.c +++ b/source/portable/NetworkInterface/STM32/Legacy/STM32Hxx/NetworkInterface.c @@ -392,8 +392,8 @@ static BaseType_t xSTM32H_NetworkInterfaceInitialise( NetworkInterface_t * pxInt #if ( ipconfigZERO_COPY_RX_DRIVER != 0 ) { - /* Subtracted 'ipBUFFER_PADDING', which is the size of the meta data. */ - pucBuffer = pucGetRXBuffer( ETH_RX_BUF_SIZE - ipBUFFER_PADDING ); + /* Subtracted 'ipBUFFER_PADDING', which is the size of the meta data. */ + pucBuffer = pucGetRXBuffer( ETH_RX_BUF_SIZE - ipBUFFER_PADDING ); configASSERT( pucBuffer != NULL ); } #else @@ -1047,7 +1047,7 @@ size_t uxNetworkInterfaceAllocateRAMToBuffers( NetworkBufferDescriptor_t pxNetwo ucRAMBuffer += ETH_RX_BUF_SIZE; } - return (ETH_RX_BUF_SIZE - ipBUFFER_PADDING); + return( ETH_RX_BUF_SIZE - ipBUFFER_PADDING ); } /*-----------------------------------------------------------*/