Address review comments

kar-rahul-aws · kar-rahul-aws · commit e82d127afa43 · 2025-04-14T07:40:39.000Z
diff --git a/source/core_sntp_serializer.c b/source/core_sntp_serializer.c
@@ -832,13 +832,13 @@ SntpStatus_t Sntp_ConvertToUnixTime( const SntpTimestamp_t * pSntpTime,
              *                                        +
              *                           Sntp Time since Era 1 Epoch
              */
-            *pUnixTimeSecs = ( UnixTime_t ) ( UNIX_TIME_SECS_AT_SNTP_ERA_1_SMALLEST_TIME + pSntpTime->seconds );
+            *pUnixTimeSecs = ( UnixTime_t ) ( UNIX_TIME_SECS_AT_SNTP_ERA_1_SMALLEST_TIME + ( UnixTime_t ) ( pSntpTime->seconds ) );
         }
 
         /* Handle case when SNTP timestamp is in SNTP era 1 time range. */
         if( pSntpTime->seconds >= SNTP_TIME_AT_UNIX_EPOCH_SECS )
         {
-            *pUnixTimeSecs = ( UnixTime_t ) ( pSntpTime->seconds - SNTP_TIME_AT_UNIX_EPOCH_SECS );
+            *pUnixTimeSecs = ( UnixTime_t ) ( ( UnixTime_t ) ( pSntpTime->seconds ) - SNTP_TIME_AT_UNIX_EPOCH_SECS );
         }
 
         /* Convert SNTP fractions to microseconds for UNIX time. */

Original file line number	Diff line number	Diff line change
`@@ -832,13 +832,13 @@ SntpStatus_t Sntp_ConvertToUnixTime( const SntpTimestamp_t * pSntpTime,`
`832`	`832`	`* +`
`833`	`833`	`* Sntp Time since Era 1 Epoch`
`834`	`834`	`*/`
`835`		`- *pUnixTimeSecs = ( UnixTime_t ) ( UNIX_TIME_SECS_AT_SNTP_ERA_1_SMALLEST_TIME + pSntpTime->seconds );`
	`835`	`+ *pUnixTimeSecs = ( UnixTime_t ) ( UNIX_TIME_SECS_AT_SNTP_ERA_1_SMALLEST_TIME + ( UnixTime_t ) ( pSntpTime->seconds ) );`
`836`	`836`	`}`
`837`	`837`
`838`	`838`	`/* Handle case when SNTP timestamp is in SNTP era 1 time range. */`
`839`	`839`	`if( pSntpTime->seconds >= SNTP_TIME_AT_UNIX_EPOCH_SECS )`
`840`	`840`	`{`
`841`		`- *pUnixTimeSecs = ( UnixTime_t ) ( pSntpTime->seconds - SNTP_TIME_AT_UNIX_EPOCH_SECS );`
	`841`	`+ *pUnixTimeSecs = ( UnixTime_t ) ( ( UnixTime_t ) ( pSntpTime->seconds ) - SNTP_TIME_AT_UNIX_EPOCH_SECS );`
`842`	`842`	`}`
`843`	`843`
`844`	`844`	`/* Convert SNTP fractions to microseconds for UNIX time. */`