Skip to content

Commit 83c9538

Browse files
committed
freertos-integration-tests: Remove OTA update dependencies
Since we don't run OTA tests as part of the intgeration tests anymore, we don't need to sign the update binary and there is no need to upload the update binary to AWS. Signed-off-by: Ahmed Ismail <[email protected]>
1 parent d60d0f8 commit 83c9538

File tree

2 files changed

+1
-65
lines changed

2 files changed

+1
-65
lines changed

applications/freertos_iot_libraries_tests/CMakeLists.txt

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,7 @@ cmake_minimum_required(VERSION 3.21.0 FATAL_ERROR)
66

77
set(AWS_OTA_SIGNATURE_TYPE "RSA-3072" CACHE STRING "Supported algorithms for signature validation [RSA-2048, RSA-3072, EC-P256, EC-P384]")
88

9-
# From: ota-for-aws-iot-embedded-sdk/source/include/ota_appversion32.h
10-
# struct version
11-
# {
12-
# uint8_t major; /*!< @brief Major version number of the firmware (X in firmware version X.Y.Z). */
13-
# uint8_t minor; /*!< @brief Minor version number of the firmware (Y in firmware version X.Y.Z). */
14-
#
15-
# uint16_t build; /*!< @brief Build of the firmware (Z in firmware version X.Y.Z). */
16-
# } x; /*!< @brief Version number of the firmware. */
17-
18-
# AWS OTA client does not use the SemVer PATCH version.
19-
# Because of this, if only PATCH version is changed then the OTA will be rejected
20-
# due to same firmware version.
21-
# We will therefore change the build version from TF-M.
229
set(MCUBOOT_IMAGE_VERSION_NS "0.0.1+10")
23-
set(MCUBOOT_IMAGE_VERSION_NS_UPDATE "0.0.1+20")
2410
set(MCUBOOT_IMAGE_NUMBER 2 CACHE STRING "Total number of firmware images")
2511
set(DEFAULT_MCUBOOT_FLASH_MAP ON)
2612

@@ -56,7 +42,6 @@ list(APPEND CMAKE_MODULE_PATH ${IOT_REFERENCE_ARM_CORSTONE3XX_SOURCE_DIR}/compon
5642
list(APPEND CMAKE_MODULE_PATH ${IOT_REFERENCE_ARM_CORSTONE3XX_SOURCE_DIR}/components/security/trusted_firmware-m/integration/cmake)
5743
include(SetLinkerOptions)
5844
include(AWSIoTHelpers)
59-
include(GenerateAWSUpdateDigestAndSignature)
6045
include(MergeTfmImages)
6146
include(SignTfmImage)
6247

@@ -110,7 +95,6 @@ target_link_libraries(${CMAKE_PROJECT_NAME}
11095
freertos-ota-pal-psa
11196
fri-bsp
11297
helpers-events
113-
ota-update
11498
provisioning-lib
11599
mbedtls
116100
tfm-ns-interface
@@ -139,18 +123,6 @@ iot_reference_arm_corstone3xx_tf_m_sign_image(
139123
TRUE
140124
)
141125

142-
# The update image is not padded to fill the whole slot (no --pad), because
143-
# 1) the image to download is smaller without padding
144-
# 2) the trailer that keeps track of boot and update statuses should not be overwritten
145-
iot_reference_arm_corstone3xx_tf_m_sign_image(
146-
${CMAKE_PROJECT_NAME}
147-
"ns_image"
148-
${CMAKE_PROJECT_NAME}-update_signed
149-
${MCUBOOT_IMAGE_VERSION_NS_UPDATE}
150-
"${BINARY_DIR}/api_ns/image_signing/layout_files/signing_layout_ns.o"
151-
FALSE
152-
)
153-
154126
# A user project that consumes the ARM FRI needs to explicitly provide
155127
# addresses in order to merge images for TF-M. The addresses cannot
156128
# be easily programmatically extracted as they are defined in the linker
@@ -160,11 +132,3 @@ iot_reference_arm_corstone3xx_tf_m_merge_images(
160132
${NS_PROVISIONING_BUNDLE_LOAD_ADDRESS}
161133
${CMAKE_BINARY_DIR}/helpers/provisioning/provisioning_data.bin
162134
)
163-
164-
# Generate the AWS OTA update digest and signature
165-
iot_reference_arm_corstone3xx_generate_aws_update_digest_and_signature(
166-
${CMAKE_PROJECT_NAME}
167-
${CMAKE_PROJECT_NAME}-update_signed
168-
update-digest
169-
update-signature
170-
)

tools/tests/test_integration.py

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
1-
# Copyright (c) 2023-2024 Arm Limited. All rights reserved.
1+
# Copyright (c) 2023-2025 Arm Limited. All rights reserved.
22
# SPDX-License-Identifier: MIT
33

44
import subprocess
55
from timeit import default_timer as timer
6-
from pytest import fixture
7-
from aws_test_util import Flags, create_aws_resources, cleanup_aws_resources
86
import re
97

108
# If you have failing test cases to ignore,
@@ -17,33 +15,7 @@
1715
test_cases_to_ignore = {}
1816

1917

20-
@fixture(scope="function")
21-
def setup_resources(
22-
build_artefacts_path: str,
23-
credentials_path: str,
24-
signed_update_bin_name: str,
25-
signing_algo: str,
26-
):
27-
"""
28-
Setup resources needed to run the test.
29-
30-
build_artefacts_path: Path to all the artefacts needed to create AWS resources.
31-
credentials_path: Path to AWS credentials.
32-
signed_update_bin_name: Name of the binary to be used for the OTA update.
33-
"""
34-
flags = Flags(
35-
build_artefacts_path, credentials_path, signed_update_bin_name, signing_algo
36-
)
37-
flags = create_aws_resources(flags)
38-
try:
39-
# Caller won't actually do anything with this, but we have to yield something.
40-
yield flags
41-
finally:
42-
cleanup_aws_resources(flags)
43-
44-
4518
def test_integration(
46-
setup_resources,
4719
fvp_process: subprocess.Popen,
4820
timeout_seconds: int,
4921
):

0 commit comments

Comments
 (0)