ota-orchestrator: Add multiple enhancements and fixes

* Do not suspend OTA agent after successful update.

* vOtaNotActiveHook() should be called whenever there
are no OTA jobs available.

* Use LogDebug and LogError instead of LogInfo to
follow the previous ota-for-embedded-iot-sdk library
implementation (avoiding new issues).

Signed-off-by: Devaraj Ranganna <[email protected]>
Signed-off-by: Ahmed Ismail <[email protected]>

Author: urutva

applications/helpers/ota_orchestrator/src/ota_orchestrator.c

@@ -1075,6 +1075,7 @@ STATIC void processOTAEvents()
                 case OtaPalNewImageBootFailed:
                 case OtaPalJobDocProcessingStateInvalid:
                     LogInfo( ( "No OTA job available. \n" ) );
+                    vOtaNotActiveHook();
                     break;
             }
 
@@ -1171,11 +1172,11 @@ STATIC void processOTAEvents()
             if( activateImage() == true )
             {
                 LogInfo( ( "Activated image.\n" ) );
-                nextEvent.eventId = OtaAgentEventActivateImage;
+
+                nextEvent.eventId = OtaAgentEventRequestJobDocument;
                 OtaSendEvent_FreeRTOS( &nextEvent );
             }
 
-            otaAgentState = OtaAgentStateStopped;
             break;
 
 

applications/helpers/ota_orchestrator/src/ota_os_freertos.c

@@ -1,6 +1,6 @@
 /*
  * Copyright Amazon.com, Inc. and its affiliates. All Rights Reserved.
- * Copyright 2024 Arm Limited and/or its affiliates
+ * Copyright 2024-2025 Arm Limited and/or its affiliates
  * <[email protected]>
  *
  * SPDX-License-Identifier: MIT
@@ -67,14 +67,14 @@ OtaOsStatus_t OtaInitEvent_FreeRTOS()
     {
         otaOsStatus = OtaOsEventQueueCreateFailed;
 
-        LogInfo( ( "Failed to create OTA Event queue: "
-                   "xQueueCreateStatic returned error: "
-                   "OtaOsStatus_t=%d \n",
-                   ( int ) otaOsStatus ) );
+        LogError( ( "Failed to create OTA Event queue: "
+                    "xQueueCreateStatic returned error: "
+                    "OtaOsStatus_t=%d \n",
+                    ( int ) otaOsStatus ) );
     }
     else
     {
-        LogInfo( ( "OTA Event Queue created.\n" ) );
+        LogDebug( ( "OTA Event Queue created.\n" ) );
     }
 
     return otaOsStatus;
@@ -90,16 +90,16 @@ OtaOsStatus_t OtaSendEvent_FreeRTOS( const void * pEventMsg )
 
     if( retVal == pdTRUE )
     {
-        LogInfo( ( "OTA Event sent.\n" ) );
+        LogDebug( ( "OTA Event sent.\n" ) );
     }
     else
     {
         otaOsStatus = OtaOsEventQueueSendFailed;
 
-        LogInfo( ( "Failed to send event to OTA Event Queue: "
-                   "xQueueSendToBack returned error: "
-                   "OtaOsStatus_t=%d \n",
-                   ( int ) otaOsStatus ) );
+        LogError( ( "Failed to send event to OTA Event Queue: "
+                    "xQueueSendToBack returned error: "
+                    "OtaOsStatus_t=%d \n",
+                    ( int ) otaOsStatus ) );
     }
 
     return otaOsStatus;
@@ -114,16 +114,16 @@ OtaOsStatus_t OtaReceiveEvent_FreeRTOS( void * pEventMsg )
 
     if( retVal == pdTRUE )
     {
-        LogInfo( ( "OTA Event received \n" ) );
+        LogDebug( ( "OTA Event received \n" ) );
     }
     else
     {
         otaOsStatus = OtaOsEventQueueReceiveFailed;
 
-        LogInfo( ( "Failed to receive event or timeout from OTA Event Queue: "
-                   "xQueueReceive returned error: "
-                   "OtaOsStatus_t=%d \n",
-                   ( int ) otaOsStatus ) );
+        LogDebug( ( "Failed to receive event or timeout from OTA Event Queue: "
+                    "xQueueReceive returned error: "
+                    "OtaOsStatus_t=%d \n",
+                    ( int ) otaOsStatus ) );
     }
 
     return otaOsStatus;
@@ -133,5 +133,5 @@ void OtaDeinitEvent_FreeRTOS()
 {
     vQueueDelete( otaEventQueue );
 
-    LogInfo( ( "OTA Event Queue Deleted. \n" ) );
+    LogDebug( ( "OTA Event Queue Deleted. \n" ) );
 }