aws-iot: Refactor ota_agent_task redundant code

The function `otaAppCallback` is called upon an event such as a new
file block being received, or the OTA image being activated.
The function then redundantly checks the OTA state via `OTA_GetState`,
which reduces code clarity via duplication including redundant
calls to the ota update's active and inactive hooks.
This fix has been tested via passing Arm's internal CI.

Signed-off-by: Reuben Cartwright <[email protected]>

Author: RC-Repositories

components/aws_iot/ota_for_aws_iot_embedded_sdk/integration/src/ota_agent_task.c

@@ -599,34 +599,6 @@ STATIC void otaAppCallback( OtaJobEvent_t event,
             LogWarn( ( "Received an unhandled callback event from OTA Agent, event = %d", event ) );
             break;
     }
-
-    OtaState_t state = OTA_GetState();
-
-    switch( state )
-    {
-        case OtaAgentStateNoTransition:
-        case OtaAgentStateInit:
-        case OtaAgentStateReady:
-        case OtaAgentStateSuspended:
-        case OtaAgentStateShuttingDown:
-        case OtaAgentStateStopped:
-            LogInfo( ( "OTA not active state `%d` from OTA Agent.", state ) );
-            vOtaNotActiveHook();
-            break;
-
-        case OtaAgentStateRequestingJob:
-        case OtaAgentStateCreatingFile:
-        case OtaAgentStateRequestingFileBlock:
-        case OtaAgentStateWaitingForFileBlock:
-        case OtaAgentStateClosingFile:
-            LogInfo( ( "OTA active state `%d` from OTA Agent.", state ) );
-            vOtaActiveHook();
-            break;
-
-        case OtaAgentStateWaitingForJob:
-        default:
-            break;
-    }
 }
 
 STATIC void prvMqttJobCallback( void * pvIncomingPublishCallbackContext,