Fix stripping trailing spaces for char -> binary conversions

Check the correct behaviour using proprietary libraries.
More similar to leading stripping.
Remove a very old FIXME in the code.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Author: freddy77

src/ctlib/unittests/cs_convert.c

@@ -309,6 +309,9 @@ TEST_MAIN()
 	/* spaces, tabs and initial "0x" are ignored */
 	DO_TEST(CS_CHAR test[] = " \t \t0x616263";
 		CS_CHAR test2[] = "abc", CS_CHAR_TYPE, test, 12, CS_BINARY_TYPE, 3, CS_SUCCEED, test2, 3);
+	/* spaces and trailing tabs are ignored */
+	DO_TEST(CS_CHAR test[] = "616263 \t ";
+		CS_CHAR test2[] = "abc", CS_CHAR_TYPE, test, 9, CS_BINARY_TYPE, 3, CS_SUCCEED, test2, 3);
 	/* odd number of characters */
 	DO_TEST(CS_CHAR test[] = "61626";
 		CS_CHAR test2[] = "\x06\x16\x26", CS_CHAR_TYPE, test, 5, CS_BINARY_TYPE, 3, CS_SUCCEED, test2, 3);

src/dblib/bcp.c

@@ -1328,6 +1328,11 @@ _bcp_read_hostfile(DBPROCESS * dbproc, FILE * hostfile, bool *row_error, bool sk
 			if (collen == 0)
 				data_is_null = true;
 
+			/* To support empty strings and keep compatibility with older files empty strings
+			 * are encoded as a single NUL byte. */
+			if (collen == 1 && coldata[0] == '\0')
+				collen = 0;
+
 			/*
 			 * TODO:  
 			 *    Dates are a problem.  In theory, we should be able to read non-English dates, which

src/tds/convert.c

@@ -2013,9 +2013,8 @@ tds_convert_to_binary(int srctype, const TDS_CHAR * src, TDS_UINT srclen, int de
 			srclen -= 2;
 		}
 
-		/* ignore trailing blanks and nulls */
-		/* FIXME is good to ignore null ?? */
-		while (srclen > 0 && (src[srclen - 1] == ' ' || src[srclen - 1] == '\0'))
+		/* ignore trailing spaces and tabs */
+		while (srclen > 0 && (src[srclen - 1] == ' ' || src[srclen - 1] == '\t'))
 			--srclen;
 
 		/* a binary string output will be half the length of */