fix: local identifier verification

Author: chadsec1

logic/get_user.py

@@ -8,3 +8,24 @@ def build_initial_user_data() -> dict:
                 "ignore_new_contacts_smp": False, 
             }
         }
+
+
+def validate_identifier(identifier) -> bool:
+    if identifier.isdigit() and len(identifier) == 16:
+        return True
+
+
+    split = identifier.split("@")
+    if len(split) != 2:
+        return False
+
+    if not split[0].isdigit():
+        return False
+
+    # Max domain length is 253 bytes
+    if len(split[1] > 253):
+        return False
+
+
+    return True
+

logic/user.py

@@ -1,6 +1,6 @@
 from tkinter import messagebox
 from ui.utils import *
-from logic.get_user import check_if_contact_exists
+from logic.user import validate_identifier 
 from logic.contacts import save_contact
 from logic.storage import save_account_data
 import tkinter as tk
@@ -51,18 +51,14 @@ def add_contact(self):
             self.status.config(text="You cannot add yourself", fg="red")
             return
 
-        try:
-            # if not check_if_contact_exists(self.master.user_data, self.master.user_data_lock, contact_id):
-            #    logger.error("[BUG] This should never execute, because the server should return a 40X error code and that should cause an exception..")
-            #    return
-
-            save_contact(self.master.user_data, self.master.user_data_lock, contact_id)
-            save_account_data(self.master.user_data, self.master.user_data_lock)
-        except ValueError as e:
-            self.status.config(text=e, fg="red")
-            logger.error("Error occured while adding new contact (%s): %s ", contact_id, e)
+        if not validate_identifier(contact_id):
+            logger.debug("Identifier is invalid.")
+            self.status.config(text = "Invalid identifier", fg="red")
             return
-            
+
+        save_contact(self.master.user_data, self.master.user_data_lock, contact_id)
+        save_account_data(self.master.user_data, self.master.user_data_lock)
+        
 
         self.master.new_contact(contact_id)
         self.destroy()