[account] [addon] [license] [php-8.1] Fixed an issue with the expiration label of lifetime add-on licenses.

Author: fajardoleo

start.php

@@ -15,7 +15,7 @@
 	 *
 	 * @var string
 	 */
-	$this_sdk_version = '2.6.2.3';
+	$this_sdk_version = '2.6.2.4';
 
 	#region SDK Selection Logic --------------------------------------------------------------------
 

templates/account/partials/addon.php

@@ -31,7 +31,7 @@
     $downgrading_plan_text        = fs_text_inline( 'Downgrading your plan', 'downgrading-plan', $slug );
     $cancelling_subscription_text = fs_text_inline( 'Cancelling the subscription', 'cancelling-subscription', $slug );
     /* translators: %1$s: Either 'Downgrading your plan' or 'Cancelling the subscription' */
-    $downgrade_x_confirm_text     = fs_text_inline( '%1$s will immediately stop all future recurring payments and your %s plan license will expire in %s.', 'downgrade-x-confirm', $slug );
+    $downgrade_x_confirm_text     = fs_text_inline( '%1$s will immediately stop all future recurring payments and your %2$s plan license will expire in %3$s.', 'downgrade-x-confirm', $slug );
     $prices_increase_text         = fs_text_inline( 'Please note that we will not be able to grandfather outdated pricing for renewals/new subscriptions after a cancellation. If you choose to renew the subscription manually in the future, after a price increase, which typically occurs once a year, you will be charged the updated price.', 'pricing-increase-warning', $slug );
     $cancel_trial_confirm_text         = fs_text_inline( 'Cancelling the trial will immediately block access to all premium features. Are you sure?', 'cancel-trial-confirm', $slug );
     $after_downgrade_non_blocking_text = fs_text_inline( 'You can still enjoy all %s features but you will not have access to %s security & feature updates, nor support.', 'after-downgrade-non-blocking', $slug );
@@ -240,19 +240,19 @@
                         true
                     );
 
-                    $human_readable_license_expiration = human_time_diff( time(), strtotime( $license->expiration ) );
-                    $downgrade_confirmation_message    = sprintf(
-                        $downgrade_x_confirm_text,
-                        ( $fs_addon->is_only_premium() ? $cancelling_subscription_text : $downgrading_plan_text ),
-                        $plan->title,
-                        $human_readable_license_expiration
-                    );
-
                     $after_downgrade_message = ! $license->is_block_features ?
                         sprintf( $after_downgrade_non_blocking_text, $plan->title, $fs_addon->get_module_label( true ) ) :
                         sprintf( $after_downgrade_blocking_text, $plan->title );
 
                     if ( ! $license->is_lifetime() && $is_active_subscription ) {
+                        $human_readable_license_expiration = human_time_diff( time(), strtotime( $license->expiration ) );
+                        $downgrade_confirmation_message    = sprintf(
+                            $downgrade_x_confirm_text,
+                            ( $fs_addon->is_only_premium() ? $cancelling_subscription_text : $downgrading_plan_text ),
+                            $plan->title,
+                            $human_readable_license_expiration
+                        );
+
                         $buttons[] = fs_ui_get_action_button(
                             $fs->get_id(),
                             'account',