[static-analysis] Fix truthy/false statements.

Author: bahiirwa

includes/class-freemius.php

@@ -8019,6 +8019,7 @@ private function maybe_network_activate_addon_license( $license = null ) {
                     }
                 }
 
+                // @phpstan-ignore-next-line
                 if ( ! empty( $site_ids ) ) {
                     $this->activate_license_on_many_sites( $user, $license->secret_key, $site_ids );
                 }
@@ -8514,7 +8515,7 @@ function _deactivate_plugin_hook() {
                     unset( $this->_storage->sticky_optin_added_ms );
                 }
 
-                if ( ! empty( $storage_keys_for_removal ) ) {
+                if ( count( $storage_keys_for_removal ) > 0 ) {
                     $sites = self::get_sites();
 
                     foreach ( $sites as $site ) {
@@ -14092,7 +14093,7 @@ private function activate_license(
                         $result = $fs->activate_license_on_many_installs( $user, $license_key, $blog_2_install_map );
                     }
 
-                    if ( true === $result && ! empty( $site_ids ) ) {
+                    if ( true === $result && count( $site_ids ) > 0 ) {
                         $result = $fs->activate_license_on_many_sites( $user, $license_key, $site_ids );
                     }
                 } else {
@@ -19905,7 +19906,7 @@ private function _store_site( $store = true, $network_level_or_blog_id = null, F
                 $site = $this->_site;
             }
 
-            if ( !isset( $site ) || !is_object($site) || empty( $site->id ) ) {
+            if ( !is_object($site) || empty( $site->id ) ) {
                 $this->_logger->error( "Empty install ID, can't store site." );
 
                 return;
@@ -20039,7 +20040,7 @@ private function _store_licenses( $store = true, $module_id = false, $licenses =
                     }
                 }
 
-                if ( ! empty( $new_user_licenses_map ) ) {
+                if ( count( $new_user_licenses_map ) > 0 ) {
                     // Add new licenses.
                     $all_licenses[ $module_id ] = array_merge( array_values( $new_user_licenses_map ), $all_licenses[ $module_id ] );
                 }

includes/class-fs-plugin-updater.php

@@ -497,6 +497,7 @@ function pre_set_site_transient_update_plugins_filter( $transient_data ) {
                 return $transient_data;
             }
 
+            // @phpstan-ignore-next-line
             if ( empty( $transient_data ) ||
                  defined( 'WP_FS__UNINSTALL_MODE' )
             ) {
@@ -1046,7 +1047,7 @@ function plugins_api_filter( $data, $action = '', $args = null ) {
                         false
                     );
 
-                    if ( ! empty( $addon_plugin_data ) ) {
+                    if ( is_array( $addon_plugin_data ) && $addon_plugin_data['Version'] ) {
                         $addon_version = $addon_plugin_data['Version'];
                     }
                 }

includes/fs-plugin-info-dialog.php

@@ -229,7 +229,7 @@ function _get_addon_info_filter( $data, $action = '', $args = null ) {
                         false
                     );
 
-                    if ( ! empty( $addon_plugin_data ) ) {
+                    if ( is_array( $addon_plugin_data ) && $addon_plugin_data['Version'] ) {
                         $current_addon_version = $addon_plugin_data['Version'];
                     }
                 }

includes/managers/class-fs-admin-menu-manager.php

@@ -154,7 +154,7 @@ private function get_bool_option( &$options, $key, $default = false ) {
 		 * @param bool  $is_addon
 		 */
 		function init( $menu, $is_addon = false ) {
-			$this->_menu_exists = ( isset( $menu['slug'] ) && ! empty( $menu['slug'] ) );
+			$this->_menu_exists = ( ! empty( $menu['slug'] ) );
 			$this->_network_menu_exists = ( ! empty( $menu['network'] ) && true === $menu['network'] );
 
 			$this->_menu_slug = ( $this->_menu_exists ? $menu['slug'] : $this->_module_unique_affix );
@@ -168,7 +168,7 @@ function init( $menu, $is_addon = false ) {
 			// @deprecated
 			$this->_parent_type = 'page';
 
-			if ( isset( $menu ) ) {
+			if ( is_array( $menu ) ) {
 			    if ( ! $is_addon ) {
                     $this->_default_submenu_items = array(
                         'contact'     => $this->get_bool_option( $menu, 'contact', true ),
@@ -318,12 +318,8 @@ function is_submenu_item_visible( $id, $default = true, $ignore_menu_existence =
 				return false;
 			}
 
-			return fs_apply_filter(
-				$this->_module_unique_affix,
-				'is_submenu_visible',
-				$this->get_bool_option( $this->_default_submenu_items, $id, $default )
-			);
-		}
+            return fs_apply_filter( $this->_module_unique_affix, 'is_submenu_visible', $this->get_bool_option( $this->_default_submenu_items, $id, $default ), $id ); // @phpstan-ignore-line
+        }
 
 		/**
 		 * Calculates admin settings menu slug.

templates/account.php

@@ -157,7 +157,7 @@
 
             $site_view_params[] = $view_params;
 
-            if ( empty( $install ) ) {
+            if ( null === $install ) {
                 continue;
             }