Fix rubocop issues

Author: Freika

app/services/reverse_geocoding/places/fetch_data.rb

@@ -134,7 +134,7 @@ def save_places(places_to_create, places_to_update)
           updated_at: Time.current
         }
       end
-      Place.insert_all(place_attributes)
+      Place.insert_all(place_attributes) # rubocop:disable Rails/SkipsModelValidations
     end
 
     return unless places_to_update.any?

app/services/users/import_data/areas.rb

@@ -53,7 +53,7 @@ def filter_and_prepare_areas
       valid_areas << prepared_attributes if prepared_attributes
     end
 
-    Rails.logger.warn "Skipped #{skipped_count} areas with invalid or missing required data" if skipped_count > 0
+    Rails.logger.warn "Skipped #{skipped_count} areas with invalid or missing required data" if skipped_count.positive?
 
     valid_areas
   end
@@ -108,7 +108,9 @@ def bulk_import_areas(areas)
       batch_created = result.count
       total_created += batch_created
 
-      Rails.logger.debug "Processed batch of #{batch.size} areas, created #{batch_created}, total created: #{total_created}"
+      Rails.logger.debug(
+        "Processed batch of #{batch.size} areas, created #{batch_created}, total created: #{total_created}"
+      )
     rescue StandardError => e
       Rails.logger.error "Failed to process area batch: #{e.message}"
       Rails.logger.error "Batch size: #{batch.size}"
@@ -120,9 +122,9 @@ def bulk_import_areas(areas)
 
   def valid_area_data?(area_data)
     return false unless area_data.is_a?(Hash)
-    return false unless area_data['name'].present?
-    return false unless area_data['latitude'].present?
-    return false unless area_data['longitude'].present?
+    return false if area_data['name'].blank?
+    return false if area_data['latitude'].blank?
+    return false if area_data['longitude'].blank?
 
     true
   rescue StandardError => e

app/services/users/import_data/notifications.rb

@@ -52,7 +52,7 @@ def filter_and_prepare_notifications
       valid_notifications << prepared_attributes if prepared_attributes
     end
 
-    if skipped_count > 0
+    if skipped_count.positive?
       Rails.logger.warn "Skipped #{skipped_count} notifications with invalid or missing required data"
     end
 
@@ -64,7 +64,7 @@ def prepare_notification_attributes(notification_data)
 
     attributes['user_id'] = user.id
 
-    attributes['created_at'] = Time.current unless attributes['created_at'].present?
+    attributes['created_at'] = Time.current if attributes['created_at'].blank?
 
     attributes['updated_at'] = Time.current
 
@@ -78,15 +78,7 @@ def prepare_notification_attributes(notification_data)
   def filter_existing_notifications(notifications)
     return notifications if notifications.empty?
 
-    existing_notifications_lookup = {}
-    user.notifications.select(:title, :content, :created_at, :kind).each do |notification|
-      primary_key = [notification.title.strip, notification.content.strip]
-
-      exact_key = [notification.title.strip, notification.content.strip, normalize_timestamp(notification.created_at)]
-
-      existing_notifications_lookup[primary_key] = true
-      existing_notifications_lookup[exact_key] = true
-    end
+    lookup = build_existing_notifications_lookup
 
     notifications.reject do |notification|
       title = notification[:title]&.strip
@@ -95,7 +87,7 @@ def filter_existing_notifications(notifications)
       primary_key = [title, content]
       exact_key = [title, content, normalize_timestamp(notification[:created_at])]
 
-      if existing_notifications_lookup[primary_key] || existing_notifications_lookup[exact_key]
+      if lookup[primary_key] || lookup[exact_key]
         Rails.logger.debug "Notification already exists: #{notification[:title]}"
         true
       else
@@ -104,6 +96,18 @@ def filter_existing_notifications(notifications)
     end
   end
 
+  def build_existing_notifications_lookup
+    lookup = {}
+    user.notifications.select(:title, :content, :created_at, :kind).each do |notification|
+      title = notification.title.strip
+      content = notification.content.strip
+
+      lookup[[title, content]] = true
+      lookup[[title, content, normalize_timestamp(notification.created_at)]] = true
+    end
+    lookup
+  end
+
   def normalize_timestamp(timestamp)
     case timestamp
     when String then Time.parse(timestamp).utc.to_i
@@ -131,7 +135,9 @@ def bulk_import_notifications(notifications)
       batch_created = result.count
       total_created += batch_created
 
-      Rails.logger.debug "Processed batch of #{batch.size} notifications, created #{batch_created}, total created: #{total_created}"
+      Rails.logger.debug(
+        "Processed batch of #{batch.size} notifications, created #{batch_created}, total: #{total_created}"
+      )
     rescue StandardError => e
       Rails.logger.error "Failed to process notification batch: #{e.message}"
       Rails.logger.error "Batch size: #{batch.size}"
@@ -144,12 +150,12 @@ def bulk_import_notifications(notifications)
   def valid_notification_data?(notification_data)
     return false unless notification_data.is_a?(Hash)
 
-    unless notification_data['title'].present?
+    if notification_data['title'].blank?
       Rails.logger.error "Failed to create notification: Validation failed: Title can't be blank"
       return false
     end
 
-    unless notification_data['content'].present?
+    if notification_data['content'].blank?
       Rails.logger.error "Failed to create notification: Validation failed: Content can't be blank"
       return false
     end

app/services/users/import_data/points.rb

@@ -59,7 +59,10 @@ def finalize
     preload_reference_data unless @preloaded
     flush_batch
 
-    logger.info "Points import completed. Created: #{@total_created}. Processed #{@processed_count} valid points, skipped #{@skipped_count}."
+    logger.info(
+      "Points import completed. Created: #{@total_created}. " \
+      "Processed #{@processed_count} valid points, skipped #{@skipped_count}."
+    )
     @total_created
   end
 
@@ -98,7 +101,9 @@ def flush_batch
       batch_created = result&.count.to_i
       @total_created += batch_created
 
-      logger.debug "Processed batch of #{@buffer.size} points, created #{batch_created}, total created: #{@total_created}"
+      logger.debug(
+        "Processed batch of #{@buffer.size} points, created #{batch_created}, total created: #{@total_created}"
+      )
     rescue StandardError => e
       logger.error "Failed to process point batch: #{e.message}"
       logger.error "Batch size: #{@buffer.size}"
@@ -125,7 +130,7 @@ def preload_reference_data
     logger.debug "Loaded #{user.imports.size} imports with #{@imports_lookup.size} lookup keys"
 
     @countries_lookup = {}
-    Country.all.each do |country|
+    Country.all.find_each do |country|
       @countries_lookup[[country.name, country.iso_a2, country.iso_a3]] = country
       @countries_lookup[country.name] = country
     end
@@ -143,17 +148,19 @@ def normalize_point_keys(points)
     all_keys = points.flat_map(&:keys).uniq
 
     points.map do |point|
-      all_keys.each_with_object({}) do |key, normalized|
-        normalized[key] = point[key]
+      all_keys.index_with do |key|
+        point[key]
       end
     end
   end
 
   def valid_point_data?(point_data)
     return false unless point_data.is_a?(Hash)
-    return false unless point_data['timestamp'].present?
+    return false if point_data['timestamp'].blank?
 
-    has_lonlat = point_data['lonlat'].present? && point_data['lonlat'].is_a?(String) && point_data['lonlat'].start_with?('POINT(')
+    has_lonlat = point_data['lonlat'].present? &&
+                 point_data['lonlat'].is_a?(String) &&
+                 point_data['lonlat'].start_with?('POINT(')
     has_coordinates = point_data['longitude'].present? && point_data['latitude'].present?
 
     has_lonlat || has_coordinates

app/services/users/import_data/stats.rb

@@ -52,7 +52,7 @@ def filter_and_prepare_stats
       valid_stats << prepared_attributes if prepared_attributes
     end
 
-    Rails.logger.warn "Skipped #{skipped_count} stats with invalid or missing required data" if skipped_count > 0
+    Rails.logger.warn "Skipped #{skipped_count} stats with invalid or missing required data" if skipped_count.positive?
 
     valid_stats
   end
@@ -107,7 +107,9 @@ def bulk_import_stats(stats)
       batch_created = result.count
       total_created += batch_created
 
-      Rails.logger.debug "Processed batch of #{batch.size} stats, created #{batch_created}, total created: #{total_created}"
+      Rails.logger.debug(
+        "Processed batch of #{batch.size} stats, created #{batch_created}, total created: #{total_created}"
+      )
     rescue StandardError => e
       ExceptionReporter.call(e, 'Failed to process stat batch')
     end
@@ -118,17 +120,17 @@ def bulk_import_stats(stats)
   def valid_stat_data?(stat_data)
     return false unless stat_data.is_a?(Hash)
 
-    unless stat_data['year'].present?
+    if stat_data['year'].blank?
       Rails.logger.error "Failed to create stat: Validation failed: Year can't be blank"
       return false
     end
 
-    unless stat_data['month'].present?
+    if stat_data['month'].blank?
       Rails.logger.error "Failed to create stat: Validation failed: Month can't be blank"
       return false
     end
 
-    unless stat_data['distance'].present?
+    if stat_data['distance'].blank?
       Rails.logger.error "Failed to create stat: Validation failed: Distance can't be blank"
       return false
     end

app/services/users/import_data/trips.rb

@@ -52,7 +52,7 @@ def filter_and_prepare_trips
       valid_trips << prepared_attributes if prepared_attributes
     end
 
-    Rails.logger.warn "Skipped #{skipped_count} trips with invalid or missing required data" if skipped_count > 0
+    Rails.logger.warn "Skipped #{skipped_count} trips with invalid or missing required data" if skipped_count.positive?
 
     valid_trips
   end
@@ -119,7 +119,9 @@ def bulk_import_trips(trips)
       batch_created = result.count
       total_created += batch_created
 
-      Rails.logger.debug "Processed batch of #{batch.size} trips, created #{batch_created}, total created: #{total_created}"
+      Rails.logger.debug(
+        "Processed batch of #{batch.size} trips, created #{batch_created}, total created: #{total_created}"
+      )
     rescue StandardError => e
       ExceptionReporter.call(e, 'Failed to process trip batch')
     end