Merge pull request #37 from FrendsPlatform/FSPES-3-AddUserToGroup-empty-groups-issue

Fix KeyNotFoundException when checking empty groups for existing users

Author: MatteoDelOmbra

Frends.LDAP.AddUserToGroups/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## [1.1.0] - 2025-08-13
+### Fixed
+- Fixed KeyNotFoundException when checking empty groups for existing users.
+
 ## [1.0.1] - 2024-03-01
 ### Fixed
 - Fixed issue with UserExistsAction parameter when AD returned another error message by adding method to actually check if the user is in the group.

Frends.LDAP.AddUserToGroups/Frends.LDAP.AddUserToGroups/AddUserToGroups.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Threading;
 using System.Linq;
+using System.Collections.Generic;
 
 namespace Frends.LDAP.AddUserToGroups;
 
@@ -89,7 +90,17 @@ private static bool UserExistsInGroup(LdapConnection connection, string userDn,
 
             if (entry != null)
             {
-                LdapAttribute memberAttr = entry.GetAttribute("member");
+                LdapAttribute memberAttr;
+
+                try
+                {
+                    memberAttr = entry.GetAttribute("member");
+                }
+                catch (KeyNotFoundException)
+                {
+                    continue;
+                }
+
                 var currentMembers = memberAttr.StringValueArray;
                 if (currentMembers.Where(e => e == userDn).Any())
                     return true;

Frends.LDAP.AddUserToGroups/Frends.LDAP.AddUserToGroups/Frends.LDAP.AddUserToGroups.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
 	<TargetFrameworks>net6.0</TargetFrameworks>
-	<Version>1.0.1</Version>
+	<Version>1.1.0</Version>
 	<Authors>Frends</Authors>
 	<Copyright>Frends</Copyright>
 	<Company>Frends</Company>